[cmake-developers] [CMake 0015058]: CheckIncludeFiles uses old-style function definition

2014-08-04 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=15058 == Reported By:Nate Eldredge Assigned To:

Re: [cmake-developers] [Review Request] Topic CMakePackageConfigHelpers_build_tree

2014-08-04 Thread Brad King
On 08/04/2014 10:10 AM, Brad King wrote: > Thanks. I reverted the original topic, rebased it on 'master' with > these changes squashed into place, and pushed it as a new topic: > > CMakePackageConfigHelpers-INSTALL_PREFIX > > I merged it to 'next' for testing. Please also add a check that the

Re: [cmake-developers] NVidia Nsight Tegra

2014-08-04 Thread Brad King
On 08/04/2014 10:39 AM, coo...@megaroms.co.uk wrote: > Will this Tegra work become a generic Android generator? Or is it Tegra > specific (it looks like a modification of the Visual Studio generators)? It is specific to NVIDIA Nsight Tegra Visual Studio Edition. -Brad -- Powered by www.kitware

Re: [cmake-developers] NVidia Nsight Tegra (was: Who does CMake contract work?)

2014-08-04 Thread coordz
Will this Tegra work become a generic Android generator? Or is it Tegra specific (it looks like a modification of the Visual Studio generators)? Cheers, Tim > Date: Wed, 09 Jul 2014 10:02:48 -0400 > From: Brad King > To: cmake-developers@cmake.org > Subject: Re: [cmake-developers] NVidia Nsight

[cmake-developers] [CMake 0015057]: Cmake fails during generating VS solution files on windows 7

2014-08-04 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=15057 == Reported By:dds Assigned To: ===

Re: [cmake-developers] [PATCH] Fix broken PGI builds for liblzma.

2014-08-04 Thread Brad King
On 08/04/2014 10:09 AM, Chuck Atkins wrote: > Whoops, my mistake. Fixed. Applied, thanks: liblzma: Fix compilation with PGI compiler http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2dd17a54 -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: ht

Re: [cmake-developers] [PATCH] Fix broken PGI builds for liblzma.

2014-08-04 Thread Chuck Atkins
Whoops, my mistake. Fixed. - Chuck On Mon, Aug 4, 2014 at 10:03 AM, Brad King wrote: > On 08/04/2014 09:57 AM, Chuck Atkins wrote: > > Given that it was ported though, I'd say the better fix would be > > to remove the C99 version entirely and always use the C89 version > > without the static a

Re: [cmake-developers] [Review Request] Topic CMakePackageConfigHelpers_build_tree

2014-08-04 Thread Brad King
On 08/01/2014 09:59 AM, Daniele E. Domenichelli wrote: > I updated the CMakePackageConfigHelpers_build_tree with the requested > changed, I'm not sure how to handle this, since the branch is already > merged in next, so I added 2 commits that can be squashed to the > previous ones: > > http://cm

Re: [cmake-developers] [PATCH] Fix broken PGI builds for liblzma.

2014-08-04 Thread Chuck Atkins
> > > +#if defined(__STDC_VERSION__) && (__STDC_VERSION__ > 199901L) && \ > > Did you mean ">= 199901L" here rather than ">"? > I did, that was a typo. On 08/01/2014 02:22 PM, Chuck Atkins wrote: > > I noticed the recent merge of liblzma broke the PGI compiler. > > It is not surprising that ther

Re: [cmake-developers] [PATCH] Fix broken PGI builds for liblzma.

2014-08-04 Thread Brad King
On 08/04/2014 09:57 AM, Chuck Atkins wrote: > Given that it was ported though, I'd say the better fix would be > to remove the C99 version entirely and always use the C89 version > without the static array dimensions. See updated patch. Agreed, but that looks like the same patch again. -Brad --

Re: [cmake-developers] [PATCH] Fix broken PGI builds for liblzma.

2014-08-04 Thread Brad King
On 08/01/2014 02:22 PM, Chuck Atkins wrote: > I noticed the recent merge of liblzma broke the PGI compiler. It is not surprising that there is lingering C99 code because the library implementation was ported from C99 to C89/90 for inclusion in CMake. > +#if defined(__STDC_VERSION__) && (__STDC_VE