On 09/05/2014 10:02 AM, Bach, Pascal wrote:
>> On 09/05/2014 09:16 AM, Bach, Pascal wrote:
>> Since CMakeSystem.cmake loads the CMAKE_TOOLCHAIN_FILE, try_compile
>> should use CMAKE_VS_WINCE_SDK when the value is set in the toolchain
>> file. Is this the case when you test the changes locally?
>
> I think it would be nice to move
> get_item_rpaths() from BundleUtilities.cmake to gp_item_get_rpaths() in
> GetPrerequisites.cmake.
Well, this function is generic enough to (possible) serve other routines or
even in CMakeLists.txt, so I'd leave it as it is.
> And how does your patch or patch
On 09/05/2014 10:17 AM, Nils Gladitz wrote:
>>> On 09/05/2014 03:31 PM, Brad King wrote:
>>
>> I think the description of RunCMake can just be updated.
>> All of its tests are about running "cmake" command lines.
>
> So you see no advantage to having the distinction?
>
> E.g. if you consider test
...I would prefer to combine into something more compact.The other
infrastructure I don't think I have touched but optically it looks
very noisy.Having something that takes away repetitive tasks, more
compact and easier on the eye would be nice.
I agree. That would be nice. Feel free to reinvent
I think it would be nice to move
get_item_rpaths() from BundleUtilities.cmake to gp_item_get_rpaths() in
GetPrerequisites.cmake.
And how does your patch or patch set handle @loader_path being used in the
rpath?
Also, I think the function signature should include the rpath vs runpath
distinctio
On 09/05/2014 03:31 PM, Brad King wrote:
I think the description of RunCMake can just be updated.
All of its tests are about running "cmake" command lines.
So you see no advantage to having the distinction?
E.g. if you consider testing a set of generators (or variants of the
same generator)
> On 09/05/2014 09:16 AM, Bach, Pascal wrote:
> > I'm not clear what you mean.
> > As far as I understand the solution files that do try compile
> > are generated using the same generator that generates the
> > final solution file.
>
> A generator with the same name is used but it is not the sa
On 09/05/2014 09:50 AM, Nils Gladitz wrote:
> On 09/05/2014 03:31 PM, Brad King wrote:
>> You can use "run_cmake_command" to run arbitrary cmake command-line
>> signatures and still use the rest of the infrastructure.
>
> Ok. I just thought it would be nice to distinguish tests that don't
> confi
On 09/05/2014 03:33 PM, David Cole wrote:
I was also thinking about setting up an alternative testing
infrastructure parallel to RunCMake which runs cmake in script mode
rather than performing configuration/generation.
This already exists in a form in the Tests/CMakeTests/*TestScript*
tests.
A
On 09/05/2014 09:16 AM, Bach, Pascal wrote:
> I'm not clear what you mean.
> As far as I understand the solution files that do try compile
> are generated using the same generator that generates the
> final solution file.
A generator with the same name is used but it is not the same
instance of cm
On 09/05/2014 03:31 PM, Brad King wrote:
You can use "run_cmake_command" to run arbitrary cmake command-line
signatures and still use the rest of the infrastructure.
Ok. I just thought it would be nice to distinguish tests that don't
configure a project. (Headline for RunCMake is "This directo
I was also thinking about setting up an alternative testing
infrastructure parallel to RunCMake which runs cmake in script mode
rather than performing configuration/generation.
This already exists in a form in the Tests/CMakeTests/*TestScript*
tests.
An example:
http://www.cmake.org/gitweb?p=cm
On 09/05/2014 09:19 AM, Nils Gladitz wrote:
> Would it be ok to set the policy for cmcurl to OLD?
No, but the code could be fixed to not trigger the warning.
See similar changes here:
Check*: Allow result variables to contain regex special characters
http://cmake.org/gitweb?p=cmake.git;a=commit
On 09/05/2014 02:50 PM, Brad King wrote:
On 09/04/2014 11:58 AM, Nils Gladitz wrote:
- The dashboard submissions that bootstrap got many CMP0054
warnings. Most of them are the same warning repeated due
to presence in a macro or loop. Please update the warning
to not warn on the same li
Here is an update version of my patchset:
It also works with older versions of Windows CE but it tells the user that he
might to manually se the CMAKE_PLATFORM_TOOLSET
(I hope the resubmission is OK like this)
>From 145c3189abf84aca046f555c5452396f0e5936eb Mon Sep 17 00:00:00 2001
From: Pascal
>> Right, it gets called inside try_compile projects too. Actually
>> the SDK information will have to be propagated into those too.
>> That means it needs to go in files like CMakeSystem.cmake or
>> CMakeCCompiler.cmake that are configured in the build tree,
>> or be explicitly propagated by cmMa
On 09/04/2014 11:58 AM, Nils Gladitz wrote:
> Thanks, that actually sounds doable.
>
> I'll give it a try.
Good work on the topic so far. I have a few more thoughts:
- The dashboard submissions that bootstrap got many CMP0054
warnings. Most of them are the same warning repeated due
to pres
On 09/05/2014 07:53 AM, Adam Strzelecki wrote:
> I have sent updated 3/6 & 4/6. Rest of patches remain the same.
> I've tested on all 3 platforms: OSX, Windows & Linux.
Thanks. I've re-built the topic with those locally. I will
merge again for testing next week when some issues caused by
other t
I have sent updated 3/6 & 4/6. Rest of patches remain the same. I've tested on
all 3 platforms: OSX, Windows & Linux. Tests are now running fine.
Regards
--
Adam
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitwa
This makes rpaths populated (if any), so libraries containing @rpath will be
resolved properly.
---
Modules/BundleUtilities.cmake | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/Modules/BundleUtilities.cmake b/Modules/BundleUtilities.cmake
index
This is done by gathering LC_RPATH commands for main bundle executable and
using it for @rpath lookup in dependent frameworks.
To achieve this all utility functions now take path to executable rather than
path to its directory.
This enabled apps using @rpath to be bundled correctly, which will be
21 matches
Mail list logo
