Re: [cmake-developers] [PATCH] Fix infinite loop in file downloads if hash value not a match

2014-09-08 Thread Brad King
On 09/08/2014 03:52 PM, Alan W. Irwin wrote: > I was caught by this infinite loop issue when attempting to build > Qt5.3.1 using ExternalProject.cmake. Applied, thanks: ExternalProject: Avoid infinite loop on file download hash mismatch http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9f49ac3

Re: [cmake-developers] OS X packaging updates

2014-09-08 Thread Brad King
On 09/08/2014 01:17 PM, Brad King wrote: > On 09/05/2014 08:33 AM, Brad King wrote: >> Thanks. I've re-built the topic with those locally. > > I've merged to 'next' for testing: I had to revert again because it causes the Qt4Deploy to fail. The topic changes the signature of gp_file_type. User

[cmake-developers] [PATCH] Fix infinite loop in file downloads if hash value not a match

2014-09-08 Thread Alan W. Irwin
I was caught by this infinite loop issue when attempting to build Qt5.3.1 using ExternalProject.cmake. I used an MD5 sum value given by BLFS for the Qt5.3.1 tar.gz download which happened to be the wrong value. In my case the consequences were not too bad because I was "downloading" from a local

[cmake-developers] [CMake 0015142]: Cannot set different INTERFACE_COMPILE_DEFINITIONS for different IMPORTED_CONFIGURATIONS

2014-09-08 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=15142 == Reported By:Daniele E. Domenichelli Assigned To:

Re: [cmake-developers] OS X packaging updates

2014-09-08 Thread Brad King
On 09/05/2014 08:33 AM, Brad King wrote: > Thanks. I've re-built the topic with those locally. I've merged to 'next' for testing: BundleUtilities: Use 'find' on UNIX for fast executable lookup http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=02dfaa31 GetPrerequisites: Make sure dyld placehold

Re: [cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case

2014-09-08 Thread Brad King
On 09/08/2014 05:35 AM, Pascal Bach wrote: > Even better would be to make the search case insensitive. How do we know which flags are sensitive to case? > - set(CMAKE_CREATE_WIN32_EXE "/entry:WinMainCRTStartup") > - set(CMAKE_CREATE_CONSOLE_EXE "/entry:mainACRTStartup") > - set(_PLATFORM_LINK_

Re: [cmake-developers] Alternate if() without implicit variable expansion

2014-09-08 Thread Nils Gladitz
On 09/08/2014 04:44 PM, Brad King wrote: Good work on the revisions. Thanks. I updated the topic, squished and merged. Nils -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to suppor

Re: [cmake-developers] Alternate if() without implicit variable expansion

2014-09-08 Thread Brad King
On 09/05/2014 09:19 AM, Nils Gladitz wrote: > On 09/05/2014 02:50 PM, Brad King wrote: >> On 09/04/2014 11:58 AM, Nils Gladitz wrote: >> - The dashboard submissions that bootstrap got many CMP0054 >>warnings. Most of them are the same warning repeated due >>to presence in a macro or loop.

[cmake-developers] [CMake 0015137]: find_package(LAPACK) reports incorrect syntax in FindLAPACK.cmake

2014-09-08 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=15137 == Reported By:Eugene Shalygin Assigned To:

Re: [cmake-developers] Extracting target metadata, IDE integration

2014-09-08 Thread Brad King
On 09/03/2014 12:12 PM, Aleix Pol wrote: > On Wed, Sep 3, 2014 at 5:48 PM, Alexander Neundorf wrote: >> I still don't understand why this shouldn't be an additional >> ExtraGenerator. > > Because it's not possible to change the generator of a build directory > once it's set up. You need to nu

[cmake-developers] [CMake 0015135]: Allow properties on installed directories

2014-09-08 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=15135 == Reported By:Richard Ulrich Assigned To:

[cmake-developers] [PATCH 2/3] WINCE, VS: Propagate Subsystem and Entry point to generated solution

2014-09-08 Thread Pascal Bach
The flags /SUBSYSTEM and /ENTRY are set by Windows-MSVC.cmake depending on the system. Howver these values never ended up in the resulting VS solution. This is fixed by reading the values of CMAKE_CREATE_WIN32_EXE and CMAKE_CREATE_CONSOLE_EXE and propagates theses to the resulting XML. --- Sour

[cmake-developers] [PATCH 1/3] WINCE: Document the WINCE variable

2014-09-08 Thread Pascal Bach
From: Pascal Bach --- Help/manual/cmake-variables.7.rst |1 + Help/variable/WINCE.rst |5 + 2 files changed, 6 insertions(+) create mode 100644 Help/variable/WINCE.rst diff --git a/Help/manual/cmake-variables.7.rst b/Help/manual/cmake-variables.7.rst index 149e4ac..b00c1

[cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case

2014-09-08 Thread Pascal Bach
Currently the mapping from flags to XML elements in the Visual Studio generator is case sensitive. It only handles upper case flags so we should pass them as upper case. Even better would be to make the search case insensitive. --- Modules/Platform/Windows-MSVC.cmake | 36 +