Re: [cmake-developers] [Review Request][3.1-rc1 regression] topic fix_link-line-dedup_regression

2014-11-10 Thread Brad King
On 11/09/2014 12:05 PM, Daniele E. Domenichelli wrote: Fix regression in link order introduced by the link-line-dedup topic Thanks. I revised the implementation slightly to avoid prepending to a vector on every iteration. I've merged to 'next' for testing: Fix link line order when shared

Re: [cmake-developers] [Review Request][3.1-rc1 regression] topic fix_link-line-dedup_regression

2014-11-10 Thread Brad King
On 11/10/2014 10:46 AM, Daniele E. Domenichelli wrote: - See if it can be integrated into the Tests/Dependency test, perhaps as a new Case5 directory. Done, see: Convert the test to use C only and move it into Tests/Dependency/Case5

Re: [cmake-developers] [Review Request][3.1-rc1 regression] topic fix_link-line-dedup_regression

2014-11-10 Thread Daniele E. Domenichelli
On 10/11/14 15:18, Brad King wrote: However, the test does not fail for me even without the fix. I think for 3.1.0-rc2 I will take this fix but not the test yet. Please extend the topic to revise the test: The test fails for me on a ubuntu precise chroot using gcc 4.6.3 (I wasn't able to

Re: [cmake-developers] pause on new topics, please

2014-11-10 Thread Brad King
On 11/07/2014 09:58 AM, Brad King wrote: I need to resolve the issues with the curl update and also get Clinton's 3.1 regression fix through. This is done, but a couple more regression-fix topics now need to go through in preparation for 3.1.0-rc2, so please continue to hold off on new topics

Re: [cmake-developers] [CPack] [CPackRPM]patch for bug 15209 - handling of symbolic links

2014-11-10 Thread Brad King
On 11/08/2014 04:17 PM, Domen Vrankar wrote: Patch add support for symlink handling in RPM packages. Symlinks to directories and files are correctly recognized as such so directory symlinks are no longer prefixed with %dir. In case of relocatable RPM packages the patch also tries to make

Re: [cmake-developers] [Review Request][3.1-rc1 regression] topic fix_link-line-dedup_regression

2014-11-10 Thread Daniele E. Domenichelli
On 10/11/14 16:49, Brad King wrote: Thanks. Please rename the 'foo' and 'bar' libs to 'case5Foo' and 'case5Bar' to avoid conflict with other cases in the future. Done: Rename the 'foo' and 'bar' libs to 'case5Foo' and 'case5Bar'

Re: [cmake-developers] New command 'file(LOCK_DIRECTORY ...)'

2014-11-10 Thread Ruslan Baratov via cmake-developers
Done On 31-Oct-14 16:39, Brad King wrote: On 10/31/2014 09:07 AM, Ruslan Baratov wrote: Does anybody ready to implement it or you want me to send the patches? Please work on the patches. You can use git format-patch to format them and post here either inline or as attachments. Thanks, -Brad