Re: [cmake-developers] New command 'file(LOCK_DIRECTORY ...)'

2014-11-14 Thread Ruslan Baratov via cmake-developers
On 14-Nov-14 22:58, Brad King wrote: - Please add more test cases covering all the file(LOCK) argument processing error messages. Done. Also I've found parse issue which is based on `sscanf` behaviour, e.g. string '123xyz' will be successfully parsed as a integer (%d). Same issue for example

Re: [cmake-developers] New command 'file(LOCK_DIRECTORY ...)'

2014-11-14 Thread Brad King
On 11/14/2014 12:31 PM, Ruslan Baratov wrote: > ConvertToWindowsExtendedPath fix + tests Thanks. I started testing on Linux so far. A few more comments: - Please add more test cases covering all the file(LOCK) argument processing error messages. - Please squash in the attached patch to your

Re: [cmake-developers] Failing CMake WinStorePhone tests

2014-11-14 Thread David Cole via cmake-developers
I was hoping you'd say that! :-) On Fri, Nov 14, 2014 at 12:23 PM, Gilles Khouzam wrote: > Hi David, > > Let me take a look at what's going on. > > -Original Message- > From: Brad King [mailto:brad.k...@kitware.com] > Sent: Friday, November 14, 2014 08:38 > To: David Cole > Cc: cmake-deve

Re: [cmake-developers] Failing CMake WinStorePhone tests

2014-11-14 Thread Gilles Khouzam
Hi David, Let me take a look at what's going on. -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Friday, November 14, 2014 08:38 To: David Cole Cc: cmake-developers@cmake.org; Gilles Khouzam Subject: Re: [cmake-developers] Failing CMake WinStorePhone tests On 11/

Re: [cmake-developers] New command 'file(LOCK_DIRECTORY ...)'

2014-11-14 Thread Ruslan Baratov via cmake-developers
ConvertToWindowsExtendedPath fix + tests >From e994378d61e64136043d9db614762e79927766cb Mon Sep 17 00:00:00 2001 From: Ruslan Baratov Date: Fri, 14 Nov 2014 21:09:35 +0400 Subject: [PATCH 1/6] Add class cmFileLockResult --- Source/cmFileLockResult.cxx | 111

Re: [cmake-developers] Failing CMake WinStorePhone tests

2014-11-14 Thread Brad King
On 11/14/2014 11:27 AM, David Cole via cmake-developers wrote: > Should I expect these tests to pass using Ninja, or is that beyond the > scope of the WinStorePhone support...? The VS generator is needed for the feature, but the tests that are failing hard-code use of specific Visual Studio genera

[cmake-developers] Failing CMake WinStorePhone tests

2014-11-14 Thread David Cole via cmake-developers
Hi, The VSWinStorePhone tests are failing on my dashboard submissions: http://open.cdash.org/viewTest.php?onlyfailed&buildid=3570369 http://open.cdash.org/viewTest.php?onlyfailed&buildid=3570163 I just upgraded that machine to Windows 8.1 and Visual Studio 2013, and these dashboards run in a VS

Re: [cmake-developers] [wip/patch] Expose Ninja console pool feature for custom commands/targets

2014-11-14 Thread Peter Collingbourne
On Wed, Nov 05, 2014 at 06:35:25PM -0500, Ben Boeckel wrote: > On Wed, Nov 05, 2014 at 15:03:02 -0800, Peter Collingbourne wrote: > > On Wed, Nov 05, 2014 at 04:49:52PM -0500, Ben Boeckel wrote: > > > For the testing of it, since only Ninja supports it, maybe it would be > > > possible to run a pro

[cmake-developers] [CMake 0015252]: find_package() may list considered but not accepted package configuration files more than once

2014-11-14 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=15252 == Reported By:Nils Gladitz Assigned To: