[cmake-developers] HP-UX Curses questions

2014-11-17 Thread Ådne Hovda
Hi I'm suspecting that this block in FindCurses https://github.com/Kitware/CMake/blob/master/Modules/FindCurses.cmake#L182-L185 should go away, unless there is something I have missed. if (NOT CURSES_TINFO_HAS_CBREAK) find_library(CURSES_EXTRA_LIBRARY cur_colr HINTS ${_cursesLibDir})

Re: [cmake-developers] [PATCH v3 0/2] Add continue keyword

2014-11-17 Thread Gregor Jasny
On 15/11/14 12:36, Gregor Jasny wrote: the current version now properly checks for proper nesting of the continue keyword. To detect new scope blocks like for example a function() I hoked into the Push/PopScope functions. I just noticed that return() handling is broken. I'm also working on a

Re: [cmake-developers] New command 'file(LOCK_DIRECTORY ...)'

2014-11-17 Thread Brad King
On 11/15/2014 03:34 AM, Rolf Eike Beer wrote: Ruslan Baratov wrote: Done. Also I've found parse issue which is based on `sscanf` behaviour, e.g. string '123xyz' will be successfully parsed as a integer (%d). Same issue for example in file(STRINGS) command: I use strtol()/strtoul() for this

Re: [cmake-developers] Cannot Find MFC on Visual Studio 2013

2014-11-17 Thread Brad King
On 11/16/2014 04:12 AM, ゑ wrote: I tried to 'FIND_PACKAGE(MFC)' on VS2013(community), but MFC not found. VS2013 has no mfc120.dll but has mfc120u.dll, so I make a patch for FindMFC.cmake, This is not just the community edition but any VS 2013. The MBCS (non-unicode) versions of the MFC

[cmake-developers] Explicit custom command BYPRODUCTS

2014-11-17 Thread Brad King
Hi Folks, Picking up from this old thread: explicit custom command side-effects (was: Severe regression caused by #14972 fixes) http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/11207/focus=11225 and this issue: Add explicit specification of custom command side effect

Re: [cmake-developers] explicit custom command side-effects

2014-11-17 Thread Brad King
On 10/08/2014 10:26 AM, Brad King wrote: Both add_custom_target and add_custom_command can run operations that produce side-effects. Both commands need a way to specify any side effects they produce. Perhaps a new option like GENERATES can be added for this. For reference in list archives,

[cmake-developers] [PATCH v4 1/3] Add continue keyword (#14013)

2014-11-17 Thread Gregor Jasny
Original draft by Doug Barbieri. Signed-off-by: Gregor Jasny gja...@googlemail.com --- Help/command/continue.rst | 7 +++ Source/cmBootstrapCommands1.cxx| 2 + Source/cmContinueCommand.cxx | 21 +

[cmake-developers] [PATCH v4 0/3] Add continue keyword

2014-11-17 Thread Gregor Jasny
Hello, the current version now properly checks for proper nesting of the continue keyword. To detect new scope blocks like for example a function() I hoked into the Push/PopScope functions. I have some questions: 1) The Scope variable stack is held in a 'internal' structure that gets special

[cmake-developers] [PATCH v4 2/3] Reject continue() without loop block (#14013)

2014-11-17 Thread Gregor Jasny
To track the nested loop levels a counter is used. It gets incremented while entering a loop block (e.g. foreach or while) and gets decremented when leaving the block. Because scope borders for example at function borders must be taken into account the counter is put into a stack. With every new

[cmake-developers] [PATCH v4 3/3] Reject break() without loop scope

2014-11-17 Thread Gregor Jasny
Signed-off-by: Gregor Jasny gja...@googlemail.com --- Help/manual/cmake-policies.7.rst | 1 + Help/policy/CMP0055.rst| 17 + Source/cmBreakCommand.cxx | 33 ++ Source/cmPolicies.cxx

Re: [cmake-developers] [CMake] target_include_directories target issue

2014-11-17 Thread Daniel Pfeifer
FWD to developers list. I think this is a documentation issue. Luis Felipe Dominguez Vega lfdoming...@estudiantes.uci.cu schrieb am Mon Nov 17 2014 at 5:42:55 PM: I can't see into the source code of cmake, into the cmTargetIncludeDirectoriesCommand.cxx somethink like import the

Re: [cmake-developers] [PATCH v4 0/3] Add continue keyword

2014-11-17 Thread Brad King
On 11/17/2014 02:00 PM, Gregor Jasny wrote: the current version now properly checks for proper nesting of the continue keyword. Cool, thanks. 1) The Scope variable stack is held in a 'internal' structure that gets special treatment in the cmMakefile copy ctor. I don't know the

[cmake-developers] [PATCH] CPackRPM: unset temporary component variable fixed

2014-11-17 Thread Gauthier Lamaison
Hi there, First, I would like to thank you for your amazing work on CMake, CPack and CTest. I've been trying to make multiple RPMs using components, but it appears that the component variables such as CPACK_RPM_componentName_PACKAGE_REQUIRES are not correctly unset. Worse, they are propagated to

Re: [cmake-developers] target_include_directories target issue

2014-11-17 Thread Brad King
On 11/17/2014 02:09 PM, Daniel Pfeifer wrote: FWD to developers list. I think this is a documentation issue. Luis Felipe Dominguez Vega schrieb am Mon Nov 17 2014 at 5:42:55 PM: I can't see into the source code of cmake, into the cmTargetIncludeDirectoriesComm__and.cxx somethink

Re: [cmake-developers] [PATCH] CPackRPM: unset temporary component variable fixed

2014-11-17 Thread Brad King
On 11/17/2014 02:46 PM, Gauthier Lamaison wrote: I've been trying to make multiple RPMs using components, but it appears that the component variables such as CPACK_RPM_componentName_PACKAGE_REQUIRES are not correctly unset. Worse, they are propagated to other components (that's how I found

[cmake-developers] [CMake 0015254]: AUTOMOC ignores Q_OBJECT if preceded by non-whitespace characters

2014-11-17 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=15254 == Reported By:Jonnhy Fisher Assigned To:

Re: [cmake-developers] [PATCH] CPackRPM: unset temporary component variable fixed

2014-11-17 Thread Domen Vrankar
2014-11-17 21:09 GMT+01:00 Brad King brad.k...@kitware.com: On 11/17/2014 02:46 PM, Gauthier Lamaison wrote: I've been trying to make multiple RPMs using components, but it appears that the component variables such as CPACK_RPM_componentName_PACKAGE_REQUIRES are not correctly unset. Worse,

Re: [cmake-developers] [PATCH] CPackRPM: unset temporary component variable fixed

2014-11-17 Thread Domen Vrankar
2014-11-17 23:05 GMT+01:00 Domen Vrankar domen.vran...@gmail.com: 2014-11-17 21:09 GMT+01:00 Brad King brad.k...@kitware.com: On 11/17/2014 02:46 PM, Gauthier Lamaison wrote: I've been trying to make multiple RPMs using components, but it appears that the component variables such as

Re: [cmake-developers] Initial Attempt at Green Hill MULTI IDE Generator Support

2014-11-17 Thread Geoffrey Viola
Thanks for the feedback. I made some changes and rebased on the trunk. The hunk in Modules/CMakeSystemSpecificInformation.cmake is now just removing a blank line so it should not be needed. Removed +message(GHS-DetermineCompiler.cmake) This looks like a leftover debugging message. Removed

Re: [cmake-developers] [PATCH] CPackRPM: unset temporary component variable fixed

2014-11-17 Thread Gauthier Lamaison
Gauthier would you also be willing to write a test for this patch? Sure ! I'll dig into that. You could extend the test that is already on master branch of git repository in directory cmake/Tests/CPackComponentsForAll. MyLibCPackConfig-IgnoreGroup.cmake.in contains the location where you

Re: [cmake-developers] New command 'file(LOCK_DIRECTORY ...)'

2014-11-17 Thread Ruslan Baratov via cmake-developers
On 17-Nov-14 18:06, Brad King wrote: Yes, please change to that so a proper error can be produced for the new API when 123xyz is given as a timeout, for example. Function added cmSystemTools::StringToInt Please look at adding a case to the test suite for this. An outer process could take the

Re: [cmake-developers] Failing CMake WinStorePhone tests

2014-11-17 Thread Gilles Khouzam
Hi David, Can you give me some information on your current setup? What build of VS do you have installed, which options? I think that the detection logic for the tests is missing some cases. I'm guessing that this is similar to what I recently fixed in CMake for the express editions, the same