>From 0852339e3ab545af709246c8e767e996cb629707 Mon Sep 17 00:00:00 2001
From: wonder-mice
Date: Wed, 20 Jan 2016 18:29:58 -0800
Subject: [PATCH] Fix crash in cmExportInstallFileGenerator::FindNamespaces()
Found it when was building poco library:
The following issue has been SUBMITTED.
==
https://cmake.org/Bug/view.php?id=15929
==
Reported By:Bruce Pascoe
Assigned To:
On 01/20/2016 08:48 AM, Eric Wing wrote:
> I thought maybe setting the internal
> CMAKE_${lang}_COMPILER_ID_FLAGS_LIST or
> CMAKE_${lang}_COMPILER_ID_FLAGS
> to "-version" would fix this.
>
> But this did nothing.
Those are internal details of the CMAKE_DETERMINE_COMPILER_ID
function and are not
Thanks, Brad.
Your patch is much better. I also was looking for overload that
receives a vector, but for some reason didn't find it...
On Wed, Jan 20, 2016 at 6:01 AM, Brad King wrote:
> On 01/19/2016 09:20 PM, Andrey Pokrovskiy wrote:
>> Previous implementation had two
> On 01/19/2016 12:43 PM, Sam Thursfield wrote:
>> Imported targets are now the recommended way of dealing with external
>> library dependencies.
>
> Thanks! Applied with minor doc format fixup and merged to 'next'
> for testing:
>
> FindPNG: Create an imported PNG::PNG target (#15911)
>
On 20/01/2016 19:05, Brad King wrote:
On 01/20/2016 11:57 AM, rle...@codelibre.net wrote:
As an aside, I've found some limitations in the usability and utility of
EXPORT. These are two of the missing pieces for making the exported
configuration functional:
1) is the need to manually call
On 01/20/2016 11:57 AM, rle...@codelibre.net wrote:
>>> + INTERFACE_LIBRARIES "${PNG_LIBRARIES}")
>
> I would have expected something like
>
> set_target_properties(PNG::PNG PROPERTIES INTERFACE_LINK_LIBRARIES
> ZLIB::ZLIB)
Yes.
> after all of the "if(EXISTS... add imported link
Roger Leigh wrote:
>add_library(OME::BioFormats INTERFACE IMPORTED)
>set_target_properties(OME::BioFormats PROPERTIES
> INTERFACE_LINK_LIBRARIES ome-bioformats)
>
> It's the last two lines. Internally, the target name is ome-bioformats,
> but I actually want it to be OME::BioFormats as
Milian Wolff wrote:
>> I'm concerned that the memory usage of a daemon implementing the proposed
>> capabilities may be too large to be practical (at least without a major
>> redesign of certain structures that tend to duplicate substrings, or
>> some kind of out-of-core approach).
>
> This
rle...@codelibre.net wrote:
>>> + INTERFACE_LIBRARIES "${PNG_LIBRARIES}")
>>
>> Shouldn't this refer to zlib instead of png libraries again?
>
> I would have expected something like
>
> set_target_properties(PNG::PNG PROPERTIES INTERFACE_LINK_LIBRARIES
> ZLIB::ZLIB)
For reference, this is
Michael Scott wrote:
> If there are any problems with the proposed changes let me know.
Hi Michael,
Thanks for working on this topic over such a long time period to get it
right.
I closed
http://public.kitware.com/Bug/view.php?id=15677
and
On 01/19/2016 09:20 PM, Andrey Pokrovskiy wrote:
> Previous implementation had two issues:
> * Quotes in arguments where not escaped
> * No special treatment for arguments with spaces
Thanks for pointing this out. Please try this alternative fix:
cmake: Fix `-E time` argument passing to child
On 01/19/2016 04:39 PM, Taylor Braun-Jones wrote:
> However, these patches use the deprecated $ generator
> expression instead of $. The rest of ExternalProject.cmake
> uses $.
Oops, old habit. Revised:
ExternalProject: Simplify `cmake --build` configuration passing
On 1/19/16, Brad King wrote:
> On 01/18/2016 01:51 PM, Eric Wing wrote:
>> So the good news is I have a basic add_executable working with Swift
>> on Linux via the Makefile generator.
>>
>> It works with all Swift files, or intermixed C+Swift files. Bridging
>> header is
14 matches
Mail list logo