Re: [cmake-developers] Storage reallocation inside std::vector causing memory problem when using variable_watch

2016-03-23 Thread Brad King
On 03/23/2016 03:19 PM, Yves Frederix wrote: > See attachment for an updated patch. Thanks. Applied with minor tweaks: Avoid use-after-free when a variable watch is executed https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=77310425 -Brad -- Powered by www.kitware.com Please keep messag

Re: [cmake-developers] Storage reallocation inside std::vector causing memory problem when using variable_watch

2016-03-23 Thread Yves Frederix
Hi Brad, > Thanks! Please expand out the comment and commit message to avoid > referencing the mailing list thread. A reader should be able to > understand the problem without following such links. See attachment for an updated patch. Hope I didn't flesh it out too much ;) > >> Makes sense. I'

Re: [cmake-developers] Patch to only consider build dependencies between files in the source directory

2016-03-23 Thread Brad King
On 03/22/2016 08:23 AM, Attila Krasznahorkay wrote: > Here is my next attempt. ;-) Hopefully I'm at least getting closer... Thanks. Applied with minor tweaks: Makefile: Optionally scan only source and build trees for dependencies https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b1e1aa1e I

Re: [cmake-developers] Storage reallocation inside std::vector causing memory problem when using variable_watch

2016-03-23 Thread Brad King
On 03/23/2016 06:26 AM, Yves Frederix wrote: > Please find a patch in attachment. In order to reduce the number of > double value lookups (8378 for my simple case), I also changed the > interface of VariableAccessed to return a bool (resulting in 3 double > lookups). The patch was tested based onto

[cmake-developers] [CMake 0016033]: WiX 4.x might require new XML namespace

2016-03-23 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=16033 == Reported By:Nils Gladitz Assigned To:

Re: [cmake-developers] CPackRPM not dealing correctly with symlinks

2016-03-23 Thread Domen Vrankar
As a workaround you could set files that you would like to be excluded from symlink relocation with CPACK_RPM_USER_FILELIST or CPACK_RPM__USER_FILELIST. I'll have a look at how this could be solved for later versions of CPack. Do I understand correctly that those errors occur when a symlink is poi

Re: [cmake-developers] CPackRPM not dealing correctly with symlinks

2016-03-23 Thread Attila Krasznahorkay
Hi Brad, I did. Then I get: CMake Error at /afs/cern.ch/work/k/krasznaa/public/cmake/3.5.0/share/cmake-3.5/Modules/CPackRPM.cmake:981 (string): string begin index: 164 is out of range 0 - 156 Call Stack (most recent call first): /afs/cern.ch/work/k/krasznaa/public/cmake/3.5.0/share/cmake-3.5/

Re: [cmake-developers] CPackRPM not dealing correctly with symlinks

2016-03-23 Thread Brad King
On 03/23/2016 08:44 AM, Attila Krasznahorkay wrote: > CMake Error at /afs/cern.ch/sw/lcg/contrib/CMake/3.3.2/... Please try with CMake 3.5. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers variou

[cmake-developers] CPackRPM not dealing correctly with symlinks

2016-03-23 Thread Attila Krasznahorkay
Dear All, Not sure what's the best way to post this issue, so I thought I'd send around an e-mail first. We've been struggling with some RPM building errors in some of our projects for a while now. Finally I was able to understand what the cause of the issue is. In some cases we put symbolic l

Re: [cmake-developers] Storage reallocation inside std::vector causing memory problem when using variable_watch

2016-03-23 Thread Yves Frederix
Hi Brad, > Thanks, I missed the problem for the `return def` line. However, I > think both places are a problem. I think it is simplest to just > re-lookup the variable value at the end of the variable watch if() > block. Please find a patch in attachment. In order to reduce the number of doubl