Hi,
the code looks right to me. Thanks a lot for fixing that so quickly.
Brad is also right about the first byte. The command has the argument
already attached.
Michael
On 06/08/2016 06:46 PM, Brad King wrote:
> On 06/08/2016 12:43 PM, Rolf Eike Beer wrote:
>>> Run ranlib on archives only if t
On 06/08/2016 12:43 PM, Rolf Eike Beer wrote:
>> Run ranlib on archives only if the tool is available
>> https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ea598671
>
> Shouldn't the first check also be "cmd == ":" instead of only
> checking the first byte?
No, because the command in question
Am Mittwoch, 8. Juni 2016, 12:24:29 schrieb Brad King:
> On 06/08/2016 03:33 AM, "Michael Jäntsch" wrote:
> > the : is obviously the default for noop which is correct for
> > Linux but not for Windows. My CMakeCache has the following entry:
> > //noop for ranlib
>
> > CMAKE_RANLIB:INTERNAL=:
> I s
On 06/08/2016 03:33 AM, "Michael Jäntsch" wrote:
> the : is obviously the default for noop which is correct for
> Linux but not for Windows. My CMakeCache has the following entry:
> //noop for ranlib
> CMAKE_RANLIB:INTERNAL=:
I see that here:
https://cmake.org/gitweb?p=cmake.git;a=blob;f=Modul
Hi Tobias,
So it looks like I was completely wrong in pointing you at GetTargetFlags
to get compiler flags. It is indeed for linker flags.
On 06/08/2016 04:23 AM, Tobias Hunger wrote:
> what use is the "flags" out-parameter in cmLocalGenerator::GetTargetFlags? It
> is
> only ever set for target
On 06/07/2016 05:54 PM, Roger Leigh wrote:
> I've merged this bzip2-debug-names branch into next for testing.
Looks good, thanks.
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services
On 06/08/2016 01:24 AM, Tobias Hunger wrote:
>> cmLocalGenerator: Pass configuration to GetTargetFlags
>> https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=fe0d2241
>
> Great, thanks!
I had to revert it from 'next' because it caused several LinkFlags
test failures. The reason is that it drop
On 06/08/2016 04:05 AM, Stephen Kelly wrote:
> I have rebased it and force pushed my github branch (there are a few
> rebasing mistakes which I'll remove later).
Thanks.
> We hit issues at work that different clang-format versions have
> different behavior. There we have the luxury of providing p
Hi everybody,
what use is the "flags" out-parameter in cmLocalGenerator::GetTargetFlags? It is
only ever set for targets of type EXECUTABLE and is filled based on the *linker
language* of the target.
I really do not see any use for this information, and indeed the flag seems
unused in the cmake c
On 06/07/2016 11:42 AM, Daniel Pfeifer wrote:
> On Mon, Jun 6, 2016 at 7:24 PM, Brad King wrote:
>> On 06/06/2016 11:39 AM, Tobias Hunger wrote:
>>
>>> A big chunk of Stephen's work has not even landed in my branch yet. Since
>>> cmake
>>> reformated all the source in the meantime it is a bit ted
Ah ok. That is interesting. If I set the CMAKE_RANLIB (after my Project command) it gets executed correctly. Interesting is that this is not needed for mingw makefiles. I also do not know how to set the RANLIB properly in my toolchain file.
Either way, the : is obviously the default for noop w
11 matches
Mail list logo
