[cmake-developers] [PATCH] Improve FindGIF version detection (fix for issue #16196)

2016-07-12 Thread Ben Campbell
A fix for https://gitlab.kitware.com/cmake/cmake/issues/16196 This is my first attempt at doing anything with CMake, so I'd appreciate any feedback on my patch! In particular, the pairs of file()/string() commands seem a bit convoluted for extracting strings out of the header file - is there

[cmake-developers] [PATCH v4] Add MinGW support for FStream

2016-07-12 Thread Dāvis Mosāns
std::basic_filebuf::open(const wchar_t *) isn't part of C++ standard and it's only present for MSVC but it isn't present in libstdc++ (MinGW) so we implement this functionality using GNU libstdc++ stdio_filebuf extension and _wfopen function. --- CMakeLists.txt | 14 +++

[cmake-developers] [PATCH] CMake installation improvements

2016-07-12 Thread Konstantin Podsvirov
Hello Brad, please apply my changes. -- Regards, Konstantin Podsvirov From 56137a0f7096bae99eeb45ca83567a5ee87d4cee Mon Sep 17 00:00:00 2001 From: Konstantin Podsvirov Date: Wed, 13 Jul 2016 00:10:28 +0300 Subject: [PATCH 1/3] CMake: install COMPONENT cmcldeps Added

Re: [cmake-developers] CpackRPM doesn't escape filenames

2016-07-12 Thread Harry Mallon
Hi Brad, A simple version, which covers the main test case is shown here. The %files list in the auto spec file shows "%dist.txt" when I think it should show "%%dist.txt". Even when I manually changed it to %% it didn't work for me though. Maybe someone who knows RPM better would be able to

Re: [cmake-developers] QtAutoGenerators output in Ninja

2016-07-12 Thread Kevin Funk
On Tuesday, July 12, 2016 10:43:52 AM CEST Daniel Pfeifer wrote: > Hi, > > CMake currently puts messages like "Generating moc source" into the > buildlog. This conflicts with the convention "no output == all good". +1 > The messages blend nicely in the colorful output of Unix Makefiles, > but

[cmake-developers] QtAutoGenerators output in Ninja

2016-07-12 Thread Daniel Pfeifer
Hi, CMake currently puts messages like "Generating moc source" into the buildlog. This conflicts with the convention "no output == all good". The messages blend nicely in the colorful output of Unix Makefiles, but when using the Ninja generator, they create quite some noise. How can this be