Re: [cmake-developers] [PATCH] Discussion needed: FindBISON: refine VERBOSE feature of BISON_TARGET

I wrote new patches for each of: changing usage of VERBOSE, new option REPORT_FILE, and refactoring all of them. 0001-FindBISON-Change-usage-of-VERBOSE-file-to-VERBOSE-fi.patch Description: Binary data 0002-FindBISON-Add-REPORT_FILE-option-to-pass-report-file.patch Description: Binary data

Re: [cmake-developers] [PATCH] Discussion needed: FindBISON: refine VERBOSE feature of BISON_TARGET

On Fri, Jul 15, 2016 at 10:52:23 -0400, Brad King wrote: > On 07/15/2016 10:45 AM, Eon Jeong wrote: > > I considered that way, but doing this can't figure "VERBOSE" used > > without from never used. same empty string value. > > You could hack it with something like > > if("${ARGN}" MATCHES

Re: [cmake-developers] [PATCH] Discussion needed: FindBISON: refine VERBOSE feature of BISON_TARGET

Thanks Brad, I'll try with that hack. Eon -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake

Re: [cmake-developers] [PATCH] Discussion needed: FindBISON: refine VERBOSE feature of BISON_TARGET

On 07/15/2016 10:45 AM, Eon Jeong wrote: > I considered that way, but doing this can't figure "VERBOSE" used > without from never used. same empty string value. You could hack it with something like if("${ARGN}" MATCHES ";VERBOSE;") if the value comes back empty. -Brad -- Powered by

Re: [cmake-developers] [PATCH] Discussion needed: FindBISON: refine VERBOSE feature of BISON_TARGET

On 07/15/2016 10:35 AM, Eon Jeong wrote: > [VERBOSE []] was my hope, but it's not easy. Since FindBISON now > uses CMakeParseArguments, a keyword can't be used both as an option > and as a one-value keyword. Just make it a multi-value keyword and then reject multiple values manually after

Re: [cmake-developers] [PATCH] Discussion needed: FindBISON: refine VERBOSE feature of BISON_TARGET

2016-07-15 23:38 GMT+09:00 Brad King : > Just make it a multi-value keyword and then reject multiple values > manually after cmake_parse_arguments returns. I considered that way, but doing this can't figure "VERBOSE" used without from never used. same empty string value.

Re: [cmake-developers] Natvis support in Visual Studio

On 07/15/2016 10:23 AM, Robert Dailey wrote: > Nice, I wasn't aware that there was already a feature in place to > support this. Given that this exists, is there any point to adding an > explicit code change to support natvis files? The VS_TOOL_OVERRIDE option is nice to allow projects a path

Re: [cmake-developers] [PATCH] Discussion needed: FindBISON: refine VERBOSE feature of BISON_TARGET

Thank you clarifying the basic rules. 2016-07-15 22:33 GMT+09:00 Brad King : >> 3.5. [VERBOSE []] and [REPORT_FILE ]. In this case, >> argument of [VERBOSE ] can be either ignored or used (copying >> the report file.) This does not break compatibility at all > > I think

Re: [cmake-developers] Natvis support in Visual Studio

On Fri, Jul 15, 2016 at 9:05 AM, Brad King wrote: > VS: Add a VS_TOOL_OVERRIDE source file property > https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ed05f11d Nice, I wasn't aware that there was already a feature in place to support this. Given that this exists, is

Re: [cmake-developers] Natvis support in Visual Studio

On 07/15/2016 09:47 AM, Robert Dailey wrote: > is Kitware officially using github or gitlab? CMake exists on both The GitLab repo is used as the issue tracker (recently migrated from Mantis). The GitHub repo is offered as a convenience for the community but is not the official path for

Re: [cmake-developers] [PATCH] ninja: Generalize check for sysconf(3) call.

On 07/15/2016 06:46 AM, Raphael Kubo da Costa wrote: > Commit f9644a2d ("cmGlobalNinjaGenerator: Clarify logic for forcing use > of response files") started considering that negative command line > length values meant forcing the use of response files. > >

[cmake-developers] Natvis support in Visual Studio

Hello CMake devs, I'm writing code to support Natvis files in Visual Studio 2015 (earlier versions support this as well, I think). I found an issue regarding this here (is Kitware officially using github or gitlab? CMake exists on both): https://gitlab.kitware.com/cmake/cmake/issues/16043

Re: [cmake-developers] [PATCH] Improve FindGIF version detection (fix for issue #16196)

On 07/14/2016 06:31 PM, Ben Campbell wrote: > new patch attached! Thanks, looks good! Applied and merged to `next` for testing: FindGIF: Detect version from GIF 4.1.6 and above https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0a6c227d Once this is merged to `master` the issue should close

Re: [cmake-developers] [PATCH] Discussion needed: FindBISON: refine VERBOSE feature of BISON_TARGET

On 07/15/2016 04:51 AM, Eon Jeong wrote: > review past discussion on this issue. Thanks for summarizing. > 3.5. [VERBOSE []] and [REPORT_FILE ]. In this case, > argument of [VERBOSE ] can be either ignored or used (copying > the report file.) This does not break compatibility at all I think

Re: [cmake-developers] [PATCH] Discussion needed: FindBISON: refine VERBOSE feature of BISON_TARGET

This mail is not bound to thread because of my mistake. The original thread is [PATCH] Discussion needed: FindBISON: refine VERBOSE feature of BISON_TARGET . Any review should be made on the thread. -- Powered by

Re: [cmake-developers] [PATCH] Discussion needed: FindBISON: refine VERBOSE feature of BISON_TARGET

A year passed so long to reply for a personal reason. Adding to this list because I think it's better to review past discussion on this issue. So let's clearify: 1. Current [VERBOSE ] defines `--verbose`, so bison generates foo.output from foo.y, (generating also foo.tab.c and foo.tab.h) then

Re: [cmake-developers] [PATCH] Discussion needed: FindBISON: refine VERBOSE feature of BISON_TARGET

A year passed so long to reply for a personal reason. Adding to this list because I think it's better to review past discussion on this issue. So let's clearify: 1. Current [VERBOSE ] defines `--verbose`, so bison generates foo.output from foo.y, (generating also foo.tab.c and foo.tab.h) then