Re: [cmake-developers] [PATCH v2] FindOpenSSL: Fix detection of OpenSSL 1.1 Win32/64

2016-08-30 Thread Brad King
On 08/29/2016 04:57 PM, Alexis Murzeau wrote: > Since OpenSSL 1.1.0, Windows binaries are libcrypto and libssl instead of > the old names libeay32 and ssleay32. Thanks, applied: FindOpenSSL: Fix detection of OpenSSL 1.1 Win32/64 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ed1758f8 -Bra

Re: [cmake-developers] [patch] Expose GNUInstallDirs absolute path algorithm

2016-08-30 Thread Brad King
On 08/28/2016 01:51 PM, Roger Leigh wrote: > The macro name might need adjusting The idea looks fine to me. Typically we name module-provided APIs with the module name. How about "GNUInstallDirs_get_absolute_install_dir"? I'm also open to other suggestions. Thanks, -Brad -- Powered by www.ki

Re: [cmake-developers] [PATCH] install: correctly deal with paths in generator expressions in DIRECTORY

2016-08-30 Thread Brad King
On 08/30/2016 03:58 AM, Yves Frederix wrote: > Some time ago, I contributed generator expressions to > install(DIRECTORY). It turns out, however, that the patch was > incomplete and that there are problems in case the provided directory > starts with a generator expression and evaluates to a full p

Re: [cmake-developers] QtAutogen: Use Base32 instead of Base64 for file names

2016-08-30 Thread Brad King
On 08/28/2016 10:00 AM, Sebastian Holtermann wrote: > Base32 is a better choice IMO because it is single case and does not > generate disruptive characters like '_', '-' or '/'. > > Here are two patches that replace Base64 with Base32. Thanks. Please revise the Base32 infrastructure to simply b

[cmake-developers] [PATCH] install: correctly deal with paths in generator expressions in DIRECTORY

2016-08-30 Thread Yves Frederix
Hi, Some time ago, I contributed generator expressions to install(DIRECTORY). It turns out, however, that the patch was incomplete and that there are problems in case the provided directory starts with a generator expression and evaluates to a full path. In attachment you can find a fix for the pr