Re: [cmake-developers] OpenBSD specific patches

2012-12-06 Thread Amit Kulkarni
Sorry please forget this message. On Thu, Dec 6, 2012 at 7:10 AM, Amit Kulkarni wrote: > Brad, > > Is it possible for you to accept this chunk from > http://www.openbsd.org/cgi-bin/cvsweb/~checkout~/ports/devel/cmake/patches/patch-Modules_Platform_OpenBSD_cmake > &g

[cmake-developers] OpenBSD specific patches

2012-12-06 Thread Amit Kulkarni
Brad, Is it possible for you to accept this chunk from http://www.openbsd.org/cgi-bin/cvsweb/~checkout~/ports/devel/cmake/patches/patch-Modules_Platform_OpenBSD_cmake $OpenBSD: patch-Modules_Platform_OpenBSD_cmake,v 1.9 2012/12/05 11:32:04 dcoppa Exp $ --- Modules/Platform/OpenBSD.cmake.orig Tue

Re: [cmake-developers] OpenBSD patches: final patch for Qt3/Qt4 related stuff

2012-12-06 Thread Amit Kulkarni
> > Similarly find_program already looks in /usr/local/bin. > > > > I suspect the patch without the above hunks is sufficient. Can anyone > > on OpenBSD verify this please? > > Confirmed. "/usr/local" hunks are not needed. > > Thanks, > David Ok. Attached is the modified set of patches for Ope

Re: [cmake-developers] OpenBSD specific patches

2012-12-05 Thread Amit Kulkarni
> >> A /usr/local/lib/qt3/bin/moc exists on my machine. I think that the > >> OpenBSD environment (linker or libtool) takes care of it. David will > >> confirm here. I notice all the FindQt3 patches are /usr/local. > > > > This is an example of why we need commit messages to explain the changes. >

[cmake-developers] OpenBSD patches: final patch for Qt3/Qt4 related stuff

2012-12-05 Thread Amit Kulkarni
Commit message: Handle OpenBSD specific paths in Qt3/Qt4, allowing concurrent building and installation. Some common programs are renamed with suffixes of either 3 or 4. Also, allow qt3/qt4 installed under /usr/local to be searched and recognized appropriately. diff --git a/Modules/FindQt.cmake

Re: [cmake-developers] OpenBSD specific patches

2012-12-03 Thread Amit Kulkarni
On Mon, Dec 3, 2012 at 7:00 AM, Brad King wrote: > On 11/30/2012 04:54 PM, Amit Kulkarni wrote: >>> Thanks. Please format this as a patch series that makes changes >>> in logical groups (possibly only one file each) and explains their >>> purpose in the commit m

[cmake-developers] OpenBSD patches: part 6

2012-12-03 Thread Amit Kulkarni
Commit message: append /usr/local/bin to search path of wx-config executable diff --git a/Modules/FindwxWindows.cmake b/Modules/FindwxWindows.cmake index 4179f7b..fb43ec7 100644 --- a/Modules/FindwxWindows.cmake +++ b/Modules/FindwxWindows.cmake @@ -604,7 +604,8 @@ else() $ENV{WXWIN}/bin

[cmake-developers] OpenBSD patches: part 5

2012-12-03 Thread Amit Kulkarni
Commit message: include default path for Lua 5.1 on OpenBSD diff --git a/Modules/FindLua51.cmake b/Modules/FindLua51.cmake index eac25f5..2d7ed3d 100644 --- a/Modules/FindLua51.cmake +++ b/Modules/FindLua51.cmake @@ -28,7 +28,7 @@ find_path(LUA_INCLUDE_DIR lua.h HINTS ENV LUA_DIR - PATH_

[cmake-developers] OpenBSD patches: part 4

2012-12-03 Thread Amit Kulkarni
Commit message: set the default paths for Tcl/Tk versions 8.4/8.5 on OpenBSD diff --git a/Modules/FindTCL.cmake b/Modules/FindTCL.cmake index 2f84ae0..f649ddc 100644 --- a/Modules/FindTCL.cmake +++ b/Modules/FindTCL.cmake @@ -82,6 +82,10 @@ set(TCLTK_POSSIBLE_LIB_PATHS "${TK_LIBRARY_PATH}" "

[cmake-developers] OpenBSD patches: part 3

2012-12-03 Thread Amit Kulkarni
Commit message: set the default path for X.org on OpenBSD for Freetype diff --git a/Modules/FindFreetype.cmake b/Modules/FindFreetype.cmake index cdb46be..1df2399 100644 --- a/Modules/FindFreetype.cmake +++ b/Modules/FindFreetype.cmake @@ -46,6 +46,7 @@ find_path(FREETYPE_INCLUDE_DIR_ft2build ft2b

[cmake-developers] OpenBSD patches: part 2

2012-12-03 Thread Amit Kulkarni
Commit message: set the default JRE and JDK paths for Java versions 1.6.0 and 1.7.0 on OpenBSD diff --git a/Modules/CMakeDetermineJavaCompiler.cmake b/Modules/CMakeDetermineJavaCompiler.cmake index c4217f5..ae9f5fc 100644 --- a/Modules/CMakeDetermineJavaCompiler.cmake +++ b/Modules/CMakeDetermin

[cmake-developers] OpenBSD patches: part 1

2012-12-03 Thread Amit Kulkarni
Commit message: set OpenBSD shared library permissions to be installed without executable permission diff --git a/Modules/Platform/OpenBSD.cmake b/Modules/Platform/OpenBSD.cmake index df240e0..53cabed 100644 --- a/Modules/Platform/OpenBSD.cmake +++ b/Modules/Platform/OpenBSD.cmake @@ -16,3 +16,7

Re: [cmake-developers] OpenBSD specific patches

2012-11-30 Thread Amit Kulkarni
> Thanks. Please format this as a patch series that makes changes > in logical groups (possibly only one file each) and explains their > purpose in the commit messages. a email sent to cmake-developers@ for each file touched with a commit message? > Here are some quick comments that can guide so

Re: [cmake-developers] OpenBSD specific patches

2012-11-30 Thread Amit Kulkarni
On Fri, 30 Nov 2012 08:28:56 -0500 Brad King wrote: > On 11/29/2012 07:02 PM, Amit Kulkarni wrote: > > I am planning to submit some patches on behalf of David Coppa > > (dcoppa@openbsd), these cover patches for OpenBSD. I have mistakenly > > sent the SSH public key alrea

[cmake-developers] OpenBSD specific patches

2012-11-29 Thread Amit Kulkarni
Hi all, I am planning to submit some patches on behalf of David Coppa (dcoppa@openbsd), these cover patches for OpenBSD. I have mistakenly sent the SSH public key already. Please approve my request. David is cc'ed on the email. Thanks -- Powered by www.kitware.com Visit other Kitware open-sour