[cmake-developers] [PATCH] Fix crash in cmExportInstallFileGenerator::FindNamespaces()

2016-01-20 Thread Andrey Pokrovskiy
>From 0852339e3ab545af709246c8e767e996cb629707 Mon Sep 17 00:00:00 2001 From: wonder-mice Date: Wed, 20 Jan 2016 18:29:58 -0800 Subject: [PATCH] Fix crash in cmExportInstallFileGenerator::FindNamespaces() Found it when was building poco library: https://github.com/pocoproject/poco.git Steps to r

Re: [cmake-developers] [PATCH] Fix args handling in cmake -E time

2016-01-20 Thread Andrey Pokrovskiy
Thanks, Brad. Your patch is much better. I also was looking for overload that receives a vector, but for some reason didn't find it... On Wed, Jan 20, 2016 at 6:01 AM, Brad King wrote: > On 01/19/2016 09:20 PM, Andrey Pokrovskiy wrote: >> Previous implementation had two issues:

[cmake-developers] [PATCH] Fix args handling in cmake -E time

2016-01-19 Thread Andrey Pokrovskiy
>From 7b01d1aed22b16fd81c3ae47dd51311e9a15187a Mon Sep 17 00:00:00 2001 From: wonder-mice Date: Tue, 19 Jan 2016 18:13:10 -0800 Subject: [PATCH] Fix args handling in cmake -E time Previous implementation had two issues: * Quotes in arguments where not escaped * No special treatment for arguments

Re: [cmake-developers] CMAKE_TOOLCHAIN_FILE and ExternalProject_Add

2015-04-26 Thread Andrey Pokrovskiy
ludes the "real" > toolchain file, and then use the wrapper as your CMAKE_TOOLCHAIN_FILE > value ... ? > > > D > > > > On Sun, Apr 26, 2015 at 7:32 PM, Andrey Pokrovskiy > wrote: >> Hi, >> >> I'm using cmake and CMAKE_TOOLCHAIN_FILE to bui

[cmake-developers] CMAKE_TOOLCHAIN_FILE and ExternalProject_Add

2015-04-26 Thread Andrey Pokrovskiy
Hi, I'm using cmake and CMAKE_TOOLCHAIN_FILE to build the project and it's dependencies. Some toolchain files have additional options (like API version, target architecture, linker type, etc.) which you need to pass to cmake command with "-D" in addition to the "-DCMAKE_TOOLCHAIN_FILE=" itself. S

[cmake-developers] [PATCH] Don't log over 9000 warnings when CMAKE_TOOLCHAIN_FILE is an empty string

2015-04-22 Thread Andrey Pokrovskiy
If CMAKE_TOOLCHAIN_FILE is an empty string cmake will generate a lot of warnings: CMake Warning (dev) at CMakeSystem.cmake:6 (include): include() given empty file name (ignored). --- Modules/CMakeDetermineSystem.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modules/

Re: [cmake-developers] ExternalProject can't have interface library as a dependency

2015-04-21 Thread Andrey Pokrovskiy
e was a cmake error saying that path (include dir or library) not exists, while it should. In my case openssl is also generated as a result of an external project, so I have to use INTERFACE library. On Tue, Apr 21, 2015 at 10:10 AM, Stephen Kelly wrote: > Andrey Pokrovskiy wrote: > >>

Re: [cmake-developers] ExternalProject can't have interface library as a dependency

2015-04-21 Thread Andrey Pokrovskiy
pply the same hack to also add a file-level dependency? On Tue, Apr 21, 2015 at 8:38 AM, Brad King wrote: > On 04/21/2015 03:34 AM, Andrey Pokrovskiy wrote: >> CMake Error at >> /usr/share/cmake/share/cmake-3.2/Modules/ExternalProject.cmake:2031 >> (get_property): >>

[cmake-developers] ExternalProject can't have interface library as a dependency

2015-04-21 Thread Andrey Pokrovskiy
[Moved from cmake users mailing list] I have the following construction: ExternalProject_Add( websockets_ep DEPENDS ev openssl ...) But it so happened, that "openssl" is an INTERFACE library. It is an INTERFACE library, because I created it with add_library(openssl INTEFA

Re: [cmake-developers] [PATCH] ExternalProject_Add: Allow generator expressions in CMAKE_CACHE_ARGS

2015-04-20 Thread Andrey Pokrovskiy
ame) get_property(cmake_cache_default_args TARGET ${name} PROPERTY _EP_CMAKE_CACHE_DEFAULT_ARGS) if(cmake_cache_args OR cmake_cache_default_args) - set(_ep_cache_args_script "${tmp_dir}/${name}-cache.cmake") + set(_ep_cache_args_script "${tmp_dir}/${name}-cache-$.cmake") if(cma

Re: [cmake-developers] [PATCH] ExternalProject_Add: Allow generator expressions in CMAKE_CACHE_ARGS

2015-04-20 Thread Andrey Pokrovskiy
Please disregard my previous email, didn't notice Brad's reply. On Mon, Apr 20, 2015 at 6:25 PM, Andrey Pokrovskiy wrote: > Will it go to mainline? Is there any formal code review process? > > On Fri, Apr 17, 2015 at 10:58 AM, David Cole wrote: >> Great -- thanks fo

Re: [cmake-developers] [PATCH] ExternalProject_Add: Allow generator expressions in CMAKE_CACHE_ARGS

2015-04-20 Thread Andrey Pokrovskiy
Will it go to mainline? Is there any formal code review process? On Fri, Apr 17, 2015 at 10:58 AM, David Cole wrote: > Great -- thanks for checking. This proposed change looks reasonable to me... > > On Fri, Apr 17, 2015 at 12:27 PM, Andrey Pokrovskiy > wrote: >>> does t

Re: [cmake-developers] [PATCH] ExternalProject_Add: Allow generator expressions in CMAKE_CACHE_ARGS

2015-04-17 Thread Andrey Pokrovskiy
17, 2015 at 4:19 AM, David Cole wrote: > With this change, does the external project's configure step re-run > when you edit only the CMAKE_CACHE_ARGS for it? > > (It did with the *.in / configure_file approach...) > > > On Fri, Apr 17, 2015 at 12:55 AM, An

[cmake-developers] [PATCH] ExternalProject_Add: Allow generator expressions in CMAKE_CACHE_ARGS

2015-04-16 Thread Andrey Pokrovskiy
In current implementation of ExternalProject_Add generator expressions are supported in CMAKE_ARGS (probably by coincidence), but not in CMAKE_CACHE_ARGS. This patch will enable generators expressions in CMAKE_CACHE_ARGS. Use case: set(LIBEV_LIBRARIES $) ExternalProject_Add( ... CMAKE_CACH