Re: [cmake-developers] [PATCH] Improve FindGIF version detection (fix for issue #16196)

2016-07-14 Thread Ben Campbell
On 15/07/16 06:47, Brad King wrote: On 07/13/2016 06:59 PM, Ben Campbell wrote: I've revised my patch to: Thanks. Please use `git format-patch` and then attach it. The inline patch was corrupted and does not apply. Oop - new patch attached! 1/1 Test #268: CMakeOnly.AllFindMo

Re: [cmake-developers] [PATCH] Improve FindGIF version detection (fix for issue #16196)

2016-07-13 Thread Ben Campbell
On 14/07/16 01:52, Brad King wrote: On 07/12/2016 11:16 PM, Ben Campbell wrote: A fix for https://gitlab.kitware.com/cmake/cmake/issues/16196 Thanks! Here are some comments. [snip] Cool - very helpful! I've revised my patch to: - only scan the headerfile once - update the docs i

[cmake-developers] [PATCH] Improve FindGIF version detection (fix for issue #16196)

2016-07-12 Thread Ben Campbell
A fix for https://gitlab.kitware.com/cmake/cmake/issues/16196 This is my first attempt at doing anything with CMake, so I'd appreciate any feedback on my patch! In particular, the pairs of file()/string() commands seem a bit convoluted for extracting strings out of the header file - is there a