Re: [cmake-developers] [PATCH] Preinstall requirements support for CPack RPM generator

2014-11-21 Thread Evgeny Kalishenko
To my mind issue http://public.kitware.com/Bug/view.php?id=14769 can be resolved after the patch 2014-10-27 21:34 GMT+04:00 Rolf Eike Beer : > Am Montag, 27. Oktober 2014, 10:55:50 schrieb Brad King: > > On 10/27/2014 10:41 AM, Rolf Eike Beer wrote: > > >> if("${_RPM_SPEC_HEADER}" MATCHES "REQUIR

Re: [cmake-developers] [PATCH] Preinstall requirements support for CPack RPM generator

2014-10-27 Thread Evgeny Kalishenko
nd not using dereferences on the > > left hand side. > > Thanks. Actually I mentioned that in my first review in this thread > but forgot to check that it had been resolved in updated patches. > > It doesn't matter though because the second commit replaces that > line

Re: [cmake-developers] [PATCH] Preinstall requirements support for CPack RPM generator

2014-10-24 Thread Evgeny Kalishenko
Documentation added, authorship fixed, a couple of commits squashed. 2014-10-21 16:50 GMT+04:00 Brad King : > On 10/20/2014 12:53 PM, Evgeny Kalishenko wrote: > > The final patch version with erroneous spelling fixes. > > Thanks. Please configure your git 'user.name' so

Re: [cmake-developers] [PATCH] Preinstall requirements support for CPack RPM generator

2014-10-20 Thread Evgeny Kalishenko
The final patch version with erroneous spelling fixes. 2014-10-19 15:28 GMT+04:00 Micha Hergarden : > On 10/09/2014 07:30 PM, Evgeny Kalishenko wrote: > > Ok, thanks for the advise about STREQUAL. Explanation of s/_/(/ (from > http://www.rpm.org/max-rpm-snapshot/s1-rpm-d

Re: [cmake-developers] [PATCH] Preinstall requirements support for CPack RPM generator

2014-10-09 Thread Evgeny Kalishenko
ostun*, which tells RPM that the package depends on package foo for running the corresponding *%pre*, *%post*, *%preun*, or *%postun* script." Modified patch attached. 2014-10-09 18:03 GMT+04:00 Brad King : > On 10/08/2014 01:48 PM, Evgeny Kalishenko wrote: > > I was interested in featu

[cmake-developers] [PATCH] Preinstall requirements support for CPack RPM generator

2014-10-08 Thread Evgeny Kalishenko
I was interested in feature request http://public.kitware.com/Bug/view.php?id=14769 and made a simple patch for CPack RPM generator (attached). -- Regards, Evgeny Kalishenko From 0f05b7863f5db20a9099bf1076df880d7bc68f65 Mon Sep 17 00:00:00 2001 From: evgenyk Date: Wed, 8 Oct 2014 21:39:19 +0400