Re: [cmake-developers] [PATCH] [Module] FindPNG: Add Env Hint via PNG_ROOT

2014-06-27 Thread Brad King
On 06/27/2014 11:04 AM, Huebl, Axel wrote: This patch provides users the optional hint via the environment variable PNG_ROOT. This comes very useful when libpng is not installed in a default location and/or if several versions are installed in parallel. Typically it is not necessary to have a

Re: [cmake-developers] [PATCH] [Module] FindPNG: Add Env Hint via PNG_ROOT

2014-06-27 Thread Huebl, Axel
CMAKE_PREFIX_PATH is indeed an option, too. The main intension of the patch is to align the package with the standard functionality of other modules (Boost, MPI, HDF5 and similar). Axel On 27.06.2014 18:17, Brad King wrote: On 06/27/2014 11:04 AM, Huebl, Axel wrote: This patch provides users

Re: [cmake-developers] [PATCH] [Module] FindPNG: Add Env Hint via PNG_ROOT

2014-06-27 Thread Brad King
On 06/27/2014 12:37 PM, Huebl, Axel wrote: CMAKE_PREFIX_PATH is indeed an option, too. The main intension of the patch is to align the package with the standard functionality of other modules (Boost, MPI, HDF5 and similar). Very few modules provide _ROOT variables, and those that do have

Re: [cmake-developers] [PATCH] [Module] FindPNG: Add Env Hint via PNG_ROOT

2014-06-27 Thread Huebl, Axel
Oh you are right, even only 80 out of 297 modules respond to grep _ROOT I guess I was just spoiled by them. Thanks for the feedback and congrats on the 3.0 release! Axel On 27.06.2014 19:10, Brad King wrote: On 06/27/2014 12:37 PM, Huebl, Axel wrote: CMAKE_PREFIX_PATH is indeed an option,