Re: [cmake-developers] [PATCH] Allow LIB_SUFFIX be used as find path

On Sun, 2017-02-26 at 19:04 +0100, Christian Schmidbauer wrote: > I don't think our patches will be mutually exclusive. Agreed. > If I understand > you correctly, you are trying to make x32 auto-detectable, hence make > it work "out of the box". I like the idea and I also tried x32 >

Re: [cmake-developers] [PATCH] Allow LIB_SUFFIX be used as find path

I don't think our patches will be mutually exclusive. If I understand you correctly, you are trying to make x32 auto-detectable, hence make it work "out of the box". I like the idea and I also tried x32 auto-detection in the past, but it seemed to me that the infrastructure does not support it

Re: [cmake-developers] [PATCH] Allow LIB_SUFFIX be used as find path

On Sun, 2017-02-26 at 16:25 +, Steven Newbury wrote: > On Sun, 2017-02-26 at 16:42 +0100, Christian Schmidbauer wrote: > > Hallo, > > > > I provided a v2 of my previous patch to the ML a few hours back > > (see > > [1]), you can give it a try. I was successfully able to build llvm > > on > >

Re: [cmake-developers] [PATCH] Allow LIB_SUFFIX be used as find path

On Sun, 2017-02-26 at 16:42 +0100, Christian Schmidbauer wrote: > Hallo, > > I provided a v2 of my previous patch to the ML a few hours back (see > [1]), you can give it a try. I was successfully able to build llvm on > Gentoo, by adding the following lines to >

Re: [cmake-developers] [PATCH] Allow LIB_SUFFIX be used as find path

Hallo, I provided a v2 of my previous patch to the ML a few hours back (see [1]), you can give it a try. I was successfully able to build llvm on Gentoo, by adding the following lines to /usr/portage/eclass/cmake-utils.eclass --- aaa/cmake-utils.eclass 2017-02-07 06:44:59.0 +0100

Re: [cmake-developers] [PATCH] Allow LIB_SUFFIX be used as find path

On Fri, 2016-06-17 at 18:53 +0200, Christian Schmidbauer wrote: > On Mon, Jun 13, 2016 at 5:22 PM, Brad King > wrote: > > Hi Christian, > > > > Thanks for working on this. > > > > On 06/12/2016 05:59 AM, Christian Schmidbauer wrote: > > > A similar idea has already been

Re: [cmake-developers] [PATCH] Allow LIB_SUFFIX be used as find path

On Fri, Jun 17, 2016 at 8:10 PM, Brad King wrote: > On 06/17/2016 01:33 PM, Christian Schmidbauer wrote: >>> CMake sets the lib32/lib64 ones in its own >>> platform modules for the relevant platforms so user code never >>> needs to do it. Where in user code would it be

Re: [cmake-developers] [PATCH] Allow LIB_SUFFIX be used as find path

On 06/17/2016 01:33 PM, Christian Schmidbauer wrote: >> CMake sets the lib32/lib64 ones in its own >> platform modules for the relevant platforms so user code never >> needs to do it. Where in user code would it be done? > > In my setup, I would create a custom my-config.cmake file And that is

Re: [cmake-developers] [PATCH] Allow LIB_SUFFIX be used as find path

On Fri, Jun 17, 2016 at 7:13 PM, Brad King wrote: > On 06/17/2016 12:53 PM, Christian Schmidbauer wrote: >>> Please also add the FIND_LIBRARY_USE_CUSTOM_SUFFIX item documentation, >>> or whatever it becomes after the discussion below. >>> >> Where do you want me to document

Re: [cmake-developers] [PATCH] Allow LIB_SUFFIX be used as find path

On 06/17/2016 12:53 PM, Christian Schmidbauer wrote: >> Please also add the FIND_LIBRARY_USE_CUSTOM_SUFFIX item documentation, >> or whatever it becomes after the discussion below. >> > Where do you want me to document it? In the same places that FIND_LIBRARY_USE_LIB32_PATHS documentation was

Re: [cmake-developers] [PATCH] Allow LIB_SUFFIX be used as find path

On Mon, Jun 13, 2016 at 5:22 PM, Brad King wrote: > Hi Christian, > > Thanks for working on this. > > On 06/12/2016 05:59 AM, Christian Schmidbauer wrote: >> A similar idea has already been suggested in #10287 > > Yes. > >> and is required for bug #15594. > > That issue

Re: [cmake-developers] [PATCH] Allow LIB_SUFFIX be used as find path

Hi Christian, Thanks for working on this. On 06/12/2016 05:59 AM, Christian Schmidbauer wrote: > A similar idea has already been suggested in #10287 Yes. > and is required for bug #15594. That issue appears unrelated. Did you typo the number? > Help/command/find_library.rst

[cmake-developers] [PATCH] Allow LIB_SUFFIX be used as find path

Inspired by commit 896ad25 for bug #11260, this commit allows to use the variable LIB_SUFFIX to be used as find path as well. Allowing the find path to be more deterministic on custom setups. A similar idea has already been suggested in #10287 and is required for bug #15594. ---