Re: [cmake-developers] [PATCH] Bug fix: Dylibs inside .framework folders fails in BundleUtilities.cmake.

2016-02-11 Thread Christian Askeland
The line is now tested in my build system, on three OS'es. Everything looks OK. New patch follows: The specific cause is when e.g. /Library/Frameworks/GStreamer.framework/Versions/1.0/lib/libgio-2.0.0.dylib is detected by fixup_bundle. BundleUtilities.cmake/set_bundle_key_values() interprets

Re: [cmake-developers] [PATCH] Bug fix: Dylibs inside .framework folders fails in BundleUtilities.cmake.

2016-02-08 Thread Brad King
On 02/07/2016 11:25 AM, Christian Askeland wrote: > We could reuse the check from gp_item_default_embedded_path(), instead of > looking at the result from that function: > > if((item NOT MATCHES "\\.dylib$") AND (item MATCHES "[^/]+\\.framework/")) > > I haven't tested the line above, but can

Re: [cmake-developers] [PATCH] Bug fix: Dylibs inside .framework folders fails in BundleUtilities.cmake.

2016-02-07 Thread Christian Askeland
> On 5. feb. 2016, at 16.22, Brad King wrote: > > On 02/04/2016 01:34 PM, Christian Askeland wrote: >> The specific cause is when e.g. >> >> /Library/Frameworks/GStreamer.framework/Versions/1.0/lib/libgio-2.0.0.dylib >> >> is detected by fixup_bundle.

[cmake-developers] [PATCH] Bug fix: Dylibs inside .framework folders fails in BundleUtilities.cmake.

2016-02-04 Thread Christian Askeland
The specific cause is when e.g. /Library/Frameworks/GStreamer.framework/Versions/1.0/lib/libgio-2.0.0.dylib is detected by fixup_bundle. BundleUtilities.cmake/set_bundle_key_values() interprets this as a framework, thus doing a string replace that creates an embedded_item that is equal to the