Re: [cmake-developers] [PATCH] CMakeDetermineSystem.cmake distinguishes-MSYS-MINGW32 (was Re: Distinguishing MSYS2

2015-08-12 Thread Brad King
On 08/11/2015 05:00 PM, Ray Donnelly wrote: > You can see our patch to add MSYS2 support here: > https://github.com/Alexpux/MSYS2-packages/blob/master/cmake/cmake-3.2.3-msys.patch > .. #if defined(__MSYS__) is used and we just set CMAKE_SYSTEM_NAME to > MSYS, not MSYS2. Good start. > If we risk b

Re: [cmake-developers] [PATCH] CMakeDetermineSystem.cmake distinguishes-MSYS-MINGW32 (was Re: Distinguishing MSYS2

2015-08-11 Thread Greg Jung
> > Am I right in reading that you use both MSYS/mingw.org and > MSYS2/MinGW-w64? Most people are sloppy about terminology so it gets > confusing very easily. Half of the icons on my desktop are different mingw/msys versions :). I've been using msys2/MinGW-w64, in preference, and lately I made

Re: [cmake-developers] [PATCH] CMakeDetermineSystem.cmake distinguishes-MSYS-MINGW32 (was Re: Distinguishing MSYS2

2015-08-11 Thread Ray Donnelly
On Tue, Aug 11, 2015 at 9:09 PM, Greg Jung wrote: > Do note that I am an "observer" or "reporter" and not responsible for the > posix-version cmake in msys2. Ray Donnelly is much closer to that than I > am. > What I can do, though, is bring in the modules (.cmake files) and make sure > the change

Re: [cmake-developers] [PATCH] CMakeDetermineSystem.cmake distinguishes-MSYS-MINGW32 (was Re: Distinguishing MSYS2

2015-08-11 Thread Greg Jung
Do note that I am an "observer" or "reporter" and not responsible for the posix-version cmake in msys2. Ray Donnelly is much closer to that than I am. What I can do, though, is bring in the modules (.cmake files) and make sure the changes (already) effected there can co-exist with a normal MSYS (u

Re: [cmake-developers] [PATCH] CMakeDetermineSystem.cmake distinguishes-MSYS-MINGW32 (was Re: Distinguishing MSYS2

2015-08-11 Thread Brad King
On 08/10/2015 04:07 PM, Greg Jung wrote: > There is an msys2-specific cmake version already built along those lines, > with several patches in the modules section to parallel the CYGWIN cases, > in the msys2 distribution. It does not have a "MSYS Makefiles" generator > option but uses "Unix genera

Re: [cmake-developers] [PATCH] CMakeDetermineSystem.cmake distinguishes-MSYS-MINGW32 (was Re: Distinguishing MSYS2

2015-08-10 Thread Greg Jung
> > We need to distinguish between the original "MSYS" and "MSYS2" for > purposes of this discussion. IIUC MSYS2 is a full environment > like Cygwin. In the "Distinguishing MSYS2" thread we established > that CMake should be built for running under MSYS2 and link to > the msys-2.0.dll runtime in

Re: [cmake-developers] [PATCH] CMakeDetermineSystem.cmake distinguishes-MSYS-MINGW32 (was Re: Distinguishing MSYS2

2015-08-10 Thread Brad King
On 08/07/2015 09:47 PM, Greg Jung wrote: > Here is a patch that incorporates mingw/msys run via "MSYS Makefiles" > generator to obtain the system name via "uname -s". Thanks. Is this meant for use when running on MSYS2? Is "#if defined(__MSYS__)" the official preprocessing condition for target

[cmake-developers] [PATCH] CMakeDetermineSystem.cmake distinguishes-MSYS-MINGW32 (was Re: Distinguishing MSYS2

2015-08-07 Thread Greg Jung
Here is a patch that incorporates mingw/msys run via "MSYS Makefiles" generator to obtain the system name via "uname -s". On Fri, Aug 7, 2015 at 4:45 PM, Greg Jung wrote: > On Fri, Aug 7, 2015 at 1:16 PM, Brad King wrote: >> > On 08/07/2015 05:25 AM, Ray Donnelly wrote: >> >> CMake needs to be