Re: [cmake-developers] [PATCH] CPackRPM: Fix cross-building rpms

2015-02-15 Thread Domen Vrankar
I've finally had some time to read over the Tests section, and it is a bit overwhelming. I'm going to describe the use cases for my patch and perhaps you can give me some guidance on adding an actual test. There are three, maybe four use cases: 1) native rpm (e.g. x86_64) 2) noarch rpm (a

Re: [cmake-developers] [PATCH] CPackRPM: Fix cross-building rpms

2015-02-10 Thread Joshua Clayton
I've finally had some time to read over the Tests section, and it is a bit overwhelming. I'm going to describe the use cases for my patch and perhaps you can give me some guidance on adding an actual test. There are three, maybe four use cases: 1) native rpm (e.g. x86_64) 2) noarch rpm (a noarch

Re: [cmake-developers] [PATCH] CPackRPM: Fix cross-building rpms

2015-02-03 Thread Rolf Eike Beer
# CPACK_RPM_PACKAGE_ARCHITECTURE (optional) -if(CPACK_RPM_PACKAGE_ARCHITECTURE) +if(NOT CPACK_RPM_PACKAGE_ARCHITECTURE) + execute_process(COMMAND uname -m + WORKING_DIRECTORY ${WDIR} + OUTPUT_VARIABLE CPACK_RPM_PACKAGE_ARCHITECTURE) +endif() You don't need to specify a working

Re: [cmake-developers] [PATCH] CPackRPM: Fix cross-building rpms

2015-02-03 Thread Domen Vrankar
Add the --target argument to rpmbuild Do not add a BuildArch variable to the spec file for arch specific packages BuildArch causes rpm building to fail except for noarch packages I'm not too familiar with cross compilation problems so could you please also provide a simple test case to help