On 04/21/2015 02:58 AM, Andrey Pokrovskiy wrote:
> Full patch set attached.
Thanks. I added some test infrastructure and then updated your
patch to use it to cover the new behavior. I also tweaked the
patches to add documentation and reference a relevant issue.
Applied:
ExternalProject: Allow
Thanks for your comments, Brad.
I added a patch to convert the file(WRITE) calls in
_ep_write_log_script to file(GENERATE) calls. It works OK in my tests,
but honestly I'm not confident enough in those changes. Any test
recommendations?
I also added a patch to write init and log scripts to "xxx-$
Please disregard my previous email, didn't notice Brad's reply.
On Mon, Apr 20, 2015 at 6:25 PM, Andrey Pokrovskiy
wrote:
> Will it go to mainline? Is there any formal code review process?
>
> On Fri, Apr 17, 2015 at 10:58 AM, David Cole wrote:
>> Great -- thanks for checking. This proposed chan
Will it go to mainline? Is there any formal code review process?
On Fri, Apr 17, 2015 at 10:58 AM, David Cole wrote:
> Great -- thanks for checking. This proposed change looks reasonable to me...
>
> On Fri, Apr 17, 2015 at 12:27 PM, Andrey Pokrovskiy
> wrote:
>>> does the external project's con
On 04/17/2015 01:58 PM, David Cole via cmake-developers wrote:
> Great -- thanks for checking. This proposed change looks reasonable to me...
Thanks for checking it, David.
Andrey, thanks for working on this!
On 04/17/2015 12:55 AM, Andrey Pokrovskiy wrote:
> generator expressions are supported
Great -- thanks for checking. This proposed change looks reasonable to me...
On Fri, Apr 17, 2015 at 12:27 PM, Andrey Pokrovskiy
wrote:
>> does the external project's configure step re-run when you edit only the
>> CMAKE_CACHE_ARGS for it?
>
> Yes. Verified with the following example:
>
>
>
> does the external project's configure step re-run when you edit only the
> CMAKE_CACHE_ARGS for it?
Yes. Verified with the following example:
cmake_minimum_required(VERSION 3.2)
project(CMakeExternalProjectGenExpr)
include(ExternalProject)
set(ZF_QUEUE_INSTALL_PREFIX "${CMAKE_CURRENT_B
With this change, does the external project's configure step re-run
when you edit only the CMAKE_CACHE_ARGS for it?
(It did with the *.in / configure_file approach...)
On Fri, Apr 17, 2015 at 12:55 AM, Andrey Pokrovskiy
wrote:
> In current implementation of ExternalProject_Add generator express
In current implementation of ExternalProject_Add generator expressions
are supported in CMAKE_ARGS (probably by coincidence), but not in
CMAKE_CACHE_ARGS. This patch will enable generators expressions in
CMAKE_CACHE_ARGS.
Use case:
set(LIBEV_LIBRARIES $)
ExternalProject_Add(
...
CMAKE_CACH
