Re: [cmake-developers] [PATCH] FindPNG: Create an imported PNG::PNG target

2016-01-20 Thread Stephen Kelly
rle...@codelibre.net wrote: >>> + INTERFACE_LIBRARIES "${PNG_LIBRARIES}") >> >> Shouldn't this refer to zlib instead of png libraries again? > > I would have expected something like > > set_target_properties(PNG::PNG PROPERTIES INTERFACE_LINK_LIBRARIES > ZLIB::ZLIB) For reference, this is docum

Re: [cmake-developers] [PATCH] FindPNG: Create an imported PNG::PNG target

2016-01-20 Thread Brad King
On 01/20/2016 11:57 AM, rle...@codelibre.net wrote: >>> + INTERFACE_LIBRARIES "${PNG_LIBRARIES}") > > I would have expected something like > > set_target_properties(PNG::PNG PROPERTIES INTERFACE_LINK_LIBRARIES > ZLIB::ZLIB) Yes. > after all of the "if(EXISTS... add imported link interface/lo

Re: [cmake-developers] [PATCH] FindPNG: Create an imported PNG::PNG target

2016-01-20 Thread rleigh
> On 01/19/2016 12:43 PM, Sam Thursfield wrote: >> Imported targets are now the recommended way of dealing with external >> library dependencies. > > Thanks! Applied with minor doc format fixup and merged to 'next' > for testing: > > FindPNG: Create an imported PNG::PNG target (#15911) > https:/

Re: [cmake-developers] [PATCH] FindPNG: Create an imported PNG::PNG target

2016-01-19 Thread Brad King
On 01/19/2016 12:43 PM, Sam Thursfield wrote: > Imported targets are now the recommended way of dealing with external > library dependencies. Thanks! Applied with minor doc format fixup and merged to 'next' for testing: FindPNG: Create an imported PNG::PNG target (#15911) https://cmake.org/git

[cmake-developers] [PATCH] FindPNG: Create an imported PNG::PNG target

2016-01-19 Thread Sam Thursfield
Imported targets are now the recommended way of dealing with external library dependencies. The documentation for FindPNG is rewritten slightly. This commit also adds a test case, you can run it like this: cmake ... -DCMake_TEST_FindPNG=ON ctest -R FindPNG --output-on-failure The testca