Re: [cmake-developers] [PATCH] FindProtobuf: fix wrong library list for Unix

2016-02-10 Thread Antonio Pérez Barrero
El mar., 9 feb. 2016 a las 11:13, Rolf Eike Beer () escribió: > Am 09.02.2016 11:10, schrieb Antonio Pérez Barrero: > >> > >> On 02/08/2016 04:24 PM, Antonio Pérez Barrero wrote: > >> > Yes, it is possible, but currently it's not looking for the debug > >> > library with a

Re: [cmake-developers] [PATCH] FindProtobuf: fix wrong library list for Unix

2016-02-09 Thread Antonio Pérez Barrero
> > On 02/08/2016 04:24 PM, Antonio Pérez Barrero wrote: > > Yes, it is possible, but currently it's not looking for the debug > > library with a different name, just in a different path that is > > unlikely to exist in a Unix system. > > The fact that a separate find_library is called for it and

Re: [cmake-developers] [PATCH] FindProtobuf: fix wrong library list for Unix

2016-02-09 Thread Rolf Eike Beer
Am 09.02.2016 11:10, schrieb Antonio Pérez Barrero: On 02/08/2016 04:24 PM, Antonio Pérez Barrero wrote: > Yes, it is possible, but currently it's not looking for the debug > library with a different name, just in a different path that is > unlikely to exist in a Unix system. The fact that a

[cmake-developers] [PATCH] FindProtobuf: fix wrong library list for Unix

2016-02-08 Thread Antonio Perez Barrero
Avoid looking for debug library unless configuring for MSVC. Before this change the variable PROTOBUF_LIBRARIES under unix was 'optimized;/usr/lib/libprotobuf.so;debug;/usr/lib/libprotobuf.so' --- Modules/FindProtobuf.cmake | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff

Re: [cmake-developers] [PATCH] FindProtobuf: fix wrong library list for Unix

2016-02-08 Thread Konstantin Podsvirov
Wonderful project "protobuf" ("protobuf" with a small letter "f") starting with version 3.0 (which is around the corner - now beta 2), will be built with CMake on Windows, and will contain CONFIG scripts with a description of the exported package and an imported goal. That's the name of the

Re: [cmake-developers] [PATCH] FindProtobuf: fix wrong library list for Unix

2016-02-08 Thread Brad King
On 02/08/2016 11:47 AM, Antonio Perez Barrero wrote: > Avoid looking for debug library unless configuring for MSVC. [snip] > - find_library(${name}_LIBRARY_DEBUG > - NAMES ${filename} > - PATHS > ${PROTOBUF_SRC_ROOT_FOLDER}/vsprojects/${_PROTOBUF_ARCH_DIR}Debug) > -

Re: [cmake-developers] [PATCH] FindProtobuf: fix wrong library list for Unix

2016-02-08 Thread Brad King
On 02/08/2016 04:24 PM, Antonio Pérez Barrero wrote: > Yes, it is possible, but currently it's not looking for the debug > library with a different name, just in a different path that is > unlikely to exist in a Unix system. The fact that a separate find_library is called for it and the result is

Re: [cmake-developers] [PATCH] FindProtobuf: fix wrong library list for Unix

2016-02-08 Thread Antonio Pérez Barrero
El lun., 8 feb. 2016 a las 19:28, Brad King () escribió: > On 02/08/2016 11:47 AM, Antonio Perez Barrero wrote: > > Avoid looking for debug library unless configuring for MSVC. > [snip] > > - find_library(${name}_LIBRARY_DEBUG > > - NAMES ${filename} > > -