Re: [cmake-developers] [PATCH] FindPythonLibs repaired for MINGW -vs- WIN32 version confusion

On Wed, Sep 2, 2015 at 7:59 PM, Greg Jung wrote: >> Would: >> if (MSVC) >> .. not be a better discriminator here? There's probably some people >> who use MSYS2 in conjunction with MSVC compilers. >> > If they are doing that, won't they want the MSYS-installed version? If it's >

Re: [cmake-developers] [PATCH] FindPythonLibs repaired for MINGW -vs- WIN32 version confusion

> > Would: > if (MSVC) > .. not be a better discriminator here? There's probably some people > who use MSYS2 in conjunction with MSVC compilers. > > If they are doing that, won't they want the MSYS-installed version? If it's not found then the library reverts to the windows-registered version. It

Re: [cmake-developers] [PATCH] FindPythonLibs repaired for MINGW -vs- WIN32 version confusion

> > On Wed, Sep 2, 2015 at 7:59 PM, Greg Jung wrote: > >> Would: > >> if (MSVC) > >> .. not be a better discriminator here? There's probably some people > >> who use MSYS2 in conjunction with MSVC compilers. > >> > > If they are doing that, won't they want the MSYS-installed

Re: [cmake-developers] [PATCH] FindPythonLibs repaired for MINGW -vs- WIN32 version confusion

> > As a reminder, another branch of this discussion is pending over here: > > > http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/13948/focus=13982 That devolved into another issue. This also applies to msys-1 with a targetted python installation. I don't think there are any

Re: [cmake-developers] [PATCH] FindPythonLibs repaired for MINGW -vs- WIN32 version confusion

On Wed, Sep 2, 2015 at 10:33 AM, Greg Jung wrote: > To revive this issue, I show a comparison of the CMakeCache entries for > cmake run from the same configuration, 1) cmake 3.2.3 with "old" PythonLibs > .vs. 2) cmake 3.3.1 with the new FindPythonLibs.cmake. > > Cmake 1): > > #

Re: [cmake-developers] [PATCH] FindPythonLibs repaired for MINGW -vs- WIN32 version confusion

To revive this issue, I show a comparison of the CMakeCache entries for cmake run from the same configuration, 1) cmake 3.2.3 with "old" PythonLibs .vs. 2) cmake 3.3.1 with the new FindPythonLibs.cmake. Cmake 1): # This is the CMakeCache file. # For build in directory: d:/mingw/msys32/tmp/bld-32

Re: [cmake-developers] [PATCH] FindPythonLibs repaired for MINGW -vs- WIN32 version confusion

On 09/02/2015 07:13 AM, Ray Donnelly wrote: > On Wed, Sep 2, 2015 at 10:33 AM, Greg Jung wrote: >> To revive this issue, I show a comparison of the CMakeCache entries for >> cmake run from the same configuration, 1) cmake 3.2.3 with "old" PythonLibs >> .vs. 2) cmake 3.3.1 with

Re: [cmake-developers] [PATCH] FindPythonLibs repaired for MINGW -vs- WIN32 version confusion

I have two changes in FindPythonLibs that should make for less failure in the MINGW/MSYS camp. While I support this stuff, I think for it to not break other people (who use either mingw.org/MinGW-w64 compilers or the old MSYS with 'normal' Windows CPython), If there is not a python

Re: [cmake-developers] [PATCH] FindPythonLibs repaired for MINGW -vs- WIN32 version confusion

On Fri, Aug 7, 2015 at 7:58 AM, Greg Jung gvj...@gmail.com wrote: Hi there, A patch for review: I have two changes in FindPythonLibs that should make for less failure in the MINGW/MSYS camp. I think you explicitly mean the MSYS2 camp here. We have our own Pythons (4 of them, 2 native and

[cmake-developers] [PATCH] FindPythonLibs repaired for MINGW -vs- WIN32 version confusion

Hi there, A patch for review: I have two changes in FindPythonLibs that should make for less failure in the MINGW/MSYS camp. 1. Distinguish mingw and win32. Avoid the registry lookup. if(WIN32) = if(WIN32 AND NOT (MINGW OR MSYS)) for the DEBUG library search, a full unix-style find_library