On 08/04/2014 10:09 AM, Chuck Atkins wrote:
> Whoops, my mistake. Fixed.
Applied, thanks:
liblzma: Fix compilation with PGI compiler
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2dd17a54
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
ht
Whoops, my mistake. Fixed.
- Chuck
On Mon, Aug 4, 2014 at 10:03 AM, Brad King wrote:
> On 08/04/2014 09:57 AM, Chuck Atkins wrote:
> > Given that it was ported though, I'd say the better fix would be
> > to remove the C99 version entirely and always use the C89 version
> > without the static a
>
> > +#if defined(__STDC_VERSION__) && (__STDC_VERSION__ > 199901L) && \
>
> Did you mean ">= 199901L" here rather than ">"?
>
I did, that was a typo.
On 08/01/2014 02:22 PM, Chuck Atkins wrote:
> > I noticed the recent merge of liblzma broke the PGI compiler.
>
> It is not surprising that ther
On 08/04/2014 09:57 AM, Chuck Atkins wrote:
> Given that it was ported though, I'd say the better fix would be
> to remove the C99 version entirely and always use the C89 version
> without the static array dimensions. See updated patch.
Agreed, but that looks like the same patch again.
-Brad
--
On 08/01/2014 02:22 PM, Chuck Atkins wrote:
> I noticed the recent merge of liblzma broke the PGI compiler.
It is not surprising that there is lingering C99 code because
the library implementation was ported from C99 to C89/90 for
inclusion in CMake.
> +#if defined(__STDC_VERSION__) && (__STDC_VE
On Fri, Aug 1, 2014 at 2:43 PM, "C. Bergström"
wrote:
> I'm not intimately following this issue, but I can get you access to
> pathcc/pathCC to see if we work on this as well.
I've got an older ekopath 4.0.9 and 4.0.10 install that you gave us a while
back when I was setting up some LAPACK test
On 08/ 2/14 01:27 AM, Chuck Atkins wrote:
It should be noted that the patch is really a set of workaround for
PGI compiler being broken and less to do with the code itself. If
desired, I could refactor the #if C99 test to use a
CHECK_SOURCE_COMPILES at the CMake level instead.
I'm not intima
It should be noted that the patch is really a set of workaround for PGI
compiler being broken and less to do with the code itself. If desired, I
could refactor the #if C99 test to use a CHECK_SOURCE_COMPILES at the
CMake level instead.
- Chuck
On Fri, Aug 1, 2014 at 2:22 PM, Chuck Atkins
wro
I noticed the recent merge of liblzma broke the PGI compiler. The attached
patch should address the issues:
PGC-S-0037-Syntax error: Recovery attempted by deleting keyword static
(/home/chuck/Code/cmake/source/Utilities/cmliblzma/liblzma/check/sha256.c:
84)
Once that's fixed, then the 32-bit bui
