On 07/14/2016 06:31 PM, Ben Campbell wrote:
> new patch attached!
Thanks, looks good! Applied and merged to `next` for testing:
FindGIF: Detect version from GIF 4.1.6 and above
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0a6c227d
Once this is merged to `master` the issue should close
On 15/07/16 06:47, Brad King wrote:
On 07/13/2016 06:59 PM, Ben Campbell wrote:
I've revised my patch to:
Thanks. Please use `git format-patch` and then attach it.
The inline patch was corrupted and does not apply.
Oop - new patch attached!
1/1 Test #268: CMakeOnly.AllFindModules
On 07/13/2016 06:59 PM, Ben Campbell wrote:
> I've revised my patch to:
Thanks. Please use `git format-patch` and then attach it.
The inline patch was corrupted and does not apply.
> 1/1 Test #268: CMakeOnly.AllFindModules .***Failed8.07 sec
>
> Not quite sure what the environment t
On 14/07/16 01:52, Brad King wrote:
On 07/12/2016 11:16 PM, Ben Campbell wrote:
A fix for https://gitlab.kitware.com/cmake/cmake/issues/16196
Thanks! Here are some comments.
[snip]
Cool - very helpful!
I've revised my patch to:
- only scan the headerfile once
- update the docs in the comme
On 07/12/2016 11:16 PM, Ben Campbell wrote:
> A fix for https://gitlab.kitware.com/cmake/cmake/issues/16196
Thanks! Here are some comments.
> the pairs of file()/string()
> commands seem a bit convoluted for extracting strings out of the header
> file - is there a more idiomatic approach?
You
A fix for https://gitlab.kitware.com/cmake/cmake/issues/16196
This is my first attempt at doing anything with CMake, so I'd appreciate
any feedback on my patch! In particular, the pairs of file()/string()
commands seem a bit convoluted for extracting strings out of the header
file - is there a
