[cmake-developers] [PATCH] Ninja: Use 'console' pool for CMake re-run if possible

2014-10-02 Thread Sylvain Joubert
Hi, Since Ninja 1.5, a pre-defined pool 'console' can be used for non buffered output. See http://martine.github.io/ninja/manual.html#_the_literal_console_literal_pool This patch specifies that special pool for the "build.ninja" build block if the Ninja version used is at least 1.5 This is usef

Re: [cmake-developers] [PATCH] Ninja: Use 'console' pool for CMake re-run if possible

2014-10-02 Thread Matthew Woehlke
On 2014-10-02 17:34, Sylvain Joubert wrote: > Since Ninja 1.5, a pre-defined pool 'console' can be used for non > buffered output. > See > http://martine.github.io/ninja/manual.html#_the_literal_console_literal_pool > > This patch specifies that special pool for the "build.ninja" build block > if

Re: [cmake-developers] [PATCH] Ninja: Use 'console' pool for CMake re-run if possible

2014-10-03 Thread Brad King
On 10/02/2014 06:08 PM, Matthew Woehlke wrote: > I haven't tried it yet, but I've been wanting this feature; thanks for > the patch! I tried the patch and it works well. When ninja reruns CMake one can now see the output immediately. > Please see also > http://public.kitware.com/Bug/view.php?id=

Re: [cmake-developers] [PATCH] Ninja: Use 'console' pool for CMake re-run if possible

2014-10-03 Thread Matthew Woehlke
On 2014-10-03 08:56, Brad King wrote: > On 10/02/2014 06:08 PM, Matthew Woehlke wrote: >> Please see also >> http://public.kitware.com/Bug/view.php?id=14915 which it sounds like >> this (partly) fixes; you may want to reference that in your patch or >> vice versa. > > I've applied the patch here a

Re: [cmake-developers] [PATCH] Ninja: Use 'console' pool for CMake re-run if possible

2014-10-03 Thread Sylvain Joubert
Le 03/10/2014 17:41, Matthew Woehlke a écrit : On 2014-10-03 08:56, Brad King wrote: I'll leave that to a follow-up patch if anyone wants to do it. I was sort-of hoping / encouraging that Sylvain might be interested :-). I quickly checked if it is possible. Unlike the rerun target which is

Re: [cmake-developers] [PATCH] Ninja: Use 'console' pool for CMake re-run if possible

2014-10-03 Thread Matthew Woehlke
On 2014-10-03 14:00, Sylvain Joubert wrote: > Le 03/10/2014 17:41, Matthew Woehlke a écrit : >> On 2014-10-03 08:56, Brad King wrote: >>> I'll leave that to a follow-up patch if anyone wants to do it. >> >> I was sort-of hoping / encouraging that Sylvain might be interested :-). > > I quickly chec

Re: [cmake-developers] [PATCH] Ninja: Use 'console' pool for CMake re-run if possible

2014-10-14 Thread Ben Boeckel
On Fri, Oct 03, 2014 at 20:00:00 +0200, Sylvain Joubert wrote: > Unlike the rerun target which is manually added by the Ninja generator, > the install and package targets are handled in a generic way by the > utility target generator. > > Thus, handling these targets is not as straightforward as