[cmake-developers] [PATCH] Retry Rename on Windows ERROR_SHARING_VIOLATION

2014-05-13 Thread Eric Berge
Attached is a patch which simply adds ERROR_SHARING_VIOLATION to the set of errors (currently including only ERROR_ACCESS_DENIED) to the errors that cause a rename (MoveFile) on Windows to retry. The condition was observed when two renames to the same target file name were happening simultaneously

Re: [cmake-developers] [PATCH] Retry Rename on Windows ERROR_SHARING_VIOLATION

2014-05-13 Thread Brad King
On 05/13/2014 12:25 PM, Eric Berge wrote: > Attached is a patch which simply adds ERROR_SHARING_VIOLATION Great! Applied: cmSystemTools::RenameFile: Retry on Windows ERROR_SHARING_VIOLATION http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a7e0cb1f Thanks for working this out. -Brad -- P

Re: [cmake-developers] [PATCH] Retry Rename on Windows ERROR_SHARING_VIOLATION

2014-05-13 Thread Brad King
On 05/13/2014 02:55 PM, Brad King wrote: > cmSystemTools::RenameFile: Retry on Windows ERROR_SHARING_VIOLATION > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a7e0cb1f > > Thanks for working this out. I revised the commit message: cmSystemTools::RenameFile: Retry on Windows ERROR_SHARING