Re: [cmake-developers] [PATCH 1/3] Ninja: Consider only custom commands deps as side-effects (#14972)

2014-06-30 Thread Brad King
On 06/27/2014 04:13 PM, Adam Strzelecki wrote: > Previously all explicit dependencies inside build folder were considered as > possible build command side-effects and phony rules were produced for them in > case they don't exist yet starting build. This however incorrect since regular > compile inp

[cmake-developers] [PATCH 1/3] Ninja: Consider only custom commands deps as side-effects (#14972)

2014-06-27 Thread Adam Strzelecki
Previously all explicit dependencies inside build folder were considered as possible build command side-effects and phony rules were produced for them in case they don't exist yet starting build. This however incorrect since regular compile inputs need to exist otherwise cmake will fail. Moreover t