Re: [cmake-developers] [PATCH 1/7] Refactor TargetTypeNames.

2011-10-02 Thread Peter Collingbourne
On Tue, Sep 27, 2011 at 05:32:19PM +0200, Nicolas Desprès wrote: On Tue, Sep 27, 2011 at 3:55 PM, Rolf Eike Beer e...@sf-mail.de wrote: From: Nicolas Despres nicolas.desp...@gmail.com Make it a static method instead of an array. It is safer for the type checking and if we add a new target

Re: [cmake-developers] [PATCH 1/7] Refactor TargetTypeNames.

2011-09-27 Thread Rolf Eike Beer
From: Nicolas Despres nicolas.desp...@gmail.com Make it a static method instead of an array. It is safer for the type checking and if we add a new target type we will be warned to add a case to the switch. + case cmTarget::UNKNOWN_LIBRARY: +return UNKNOWN_LIBRARY; +//

Re: [cmake-developers] [PATCH 1/7] Refactor TargetTypeNames.

2011-09-27 Thread Nicolas Desprès
On Tue, Sep 27, 2011 at 3:55 PM, Rolf Eike Beer e...@sf-mail.de wrote: From: Nicolas Despres nicolas.desp...@gmail.com Make it a static method instead of an array. It is safer for the type checking and if we add a new target type we will be warned to add a case to the switch. +      case