Re: [cmake-developers] [PATCH 2/2] FindwxWidgets.cmake: Resolve CygWin/MSYS paths to Windows paths

2016-02-17 Thread Brad King
On 02/16/2016 04:15 PM, Simon Richter wrote: > Hm, only problem is patch attribution here -- I've written that these > are from Wayne, and should be attributed to him (but submitting these > with his name in the From: field obviously would not have worked). IIRC if you commit with --author='...' t

Re: [cmake-developers] [PATCH 2/2] FindwxWidgets.cmake: Resolve CygWin/MSYS paths to Windows paths

2016-02-16 Thread Simon Richter
Hi Brad. On 16.02.2016 20:17, Brad King wrote: > I've applied the change with minor tweaks and tried to explain this > in the commit message: Hm, only problem is patch attribution here -- I've written that these are from Wayne, and should be attributed to him (but submitting these with his name

Re: [cmake-developers] [PATCH 2/2] FindwxWidgets.cmake: Resolve CygWin/MSYS paths to Windows paths

2016-02-16 Thread Brad King
On 02/16/2016 01:42 PM, Greg Jung wrote: > A true MinGW wx-config should report Windows paths. > > Good point, which is why modifying wx-config is done. > MSYS/configure ... will build wx as if it knows nothing about > windows' paths and the wx-config output works as it should, > it is an M

Re: [cmake-developers] [PATCH 2/2] FindwxWidgets.cmake: Resolve CygWin/MSYS paths to Windows paths

2016-02-16 Thread Greg Jung
> > A true MinGW wx-config should report Windows paths. Good point, which is why modifying wx-config is done. MSYS/configure ... will build wx as if it knows nothing about windows' paths and the wx-config output works as it should, it is an MSYS weakness that fails in one aspect downstream (I fo

Re: [cmake-developers] [PATCH 2/2] FindwxWidgets.cmake: Resolve CygWin/MSYS paths to Windows paths

2016-02-16 Thread Brad King
On 02/16/2016 01:16 PM, Greg Jung wrote: > Simon is working on MSYS2 for a mingw build. The MSYS2-native CMake > is a different beast, and wouldn't be producing mingw programs. Okay, then why do we need to support a MSYS2-native `wx-config` tool? A true MinGW wx-config should report Windows paths

Re: [cmake-developers] [PATCH 2/2] FindwxWidgets.cmake: Resolve CygWin/MSYS paths to Windows paths

2016-02-16 Thread Greg Jung
On Tue, Feb 16, 2016 at 9:40 AM, Brad King wrote: > On 02/16/2016 11:29 AM, Simon Richter wrote: > > The patched wx-config in MSYS2 invokes cygpath to resolve the Unix path > > they would otherwise return to a native path with forward slashes, so my > > expectation would be that it is guaranteed

Re: [cmake-developers] [PATCH 2/2] FindwxWidgets.cmake: Resolve CygWin/MSYS paths to Windows paths

2016-02-16 Thread Brad King
On 02/16/2016 11:29 AM, Simon Richter wrote: > The patched wx-config in MSYS2 invokes cygpath to resolve the Unix path > they would otherwise return to a native path with forward slashes, so my > expectation would be that it is guaranteed to exist on MSYS2. How is it that a native-Windows CMake is

Re: [cmake-developers] [PATCH 2/2] FindwxWidgets.cmake: Resolve CygWin/MSYS paths to Windows paths

2016-02-16 Thread Simon Richter
Hi, Am 16.02.2016 um 16:49 schrieb Brad King: > Thanks. Is that utility guaranteed to exist? IIRC the original MSYS > intentionally did not include such a utility. The patched wx-config in MSYS2 invokes cygpath to resolve the Unix path they would otherwise return to a native path with forward

Re: [cmake-developers] [PATCH 2/2] FindwxWidgets.cmake: Resolve CygWin/MSYS paths to Windows paths

2016-02-16 Thread Brad King
On 02/14/2016 02:51 PM, Simon Richter wrote: > CMake expects Windows style paths on MSYS, so use the cygpath utility to > resolve them. Thanks. Is that utility guaranteed to exist? IIRC the original MSYS intentionally did not include such a utility. In the past I've used a helper function like

[cmake-developers] [PATCH 2/2] FindwxWidgets.cmake: Resolve CygWin/MSYS paths to Windows paths

2016-02-14 Thread Simon Richter
CMake expects Windows style paths on MSYS, so use the cygpath utility to resolve them. --- Modules/FindwxWidgets.cmake | 28 1 file changed, 28 insertions(+) diff --git a/Modules/FindwxWidgets.cmake b/Modules/FindwxWidgets.cmake index 12cb1ca..ed34216 100644 --- a/Mod