Re: [cmake-developers] [PATCH V2] FindPNG: Create an imported PNG::PNG target

2016-01-21 Thread Brad King
On 01/21/2016 11:46 AM, Sam Thursfield wrote: > Imported targets are now the recommended way of dealing with external > library dependencies. Thanks, re-applied and merged to 'next' for testing: FindPNG: Create an imported PNG::PNG target (#15911) https://cmake.org/gitweb?p=cmake.git;a=commitdi

[cmake-developers] [PATCH V2] FindPNG: Create an imported PNG::PNG target

2016-01-21 Thread Sam Thursfield
Updated to refer to ZLIB::ZLIB, and with documentation tweak. Sam Thursfield (1): FindPNG: Create an imported PNG::PNG target Help/release/dev/FindPNG-imported-targets.rst | 4 +++ Modules/FindPNG.cmake | 50 +++ Tests/CMakeLists.txt

[cmake-developers] [PATCH V2] FindPNG: Create an imported PNG::PNG target

2016-01-21 Thread Sam Thursfield
Imported targets are now the recommended way of dealing with external library dependencies. The documentation for FindPNG is rewritten slightly. This commit also adds a test case, you can run it like this: cmake ... -DCMake_TEST_FindPNG=ON ctest -R FindPNG --output-on-failure The testca