Re: [cmake-developers] [Patch] ExternalProject: fix retry logic if error occurs

2016-05-19 Thread Brad King
On 05/19/2016 09:49 AM, Ruslan Baratov wrote: > It's a little bit tricky to split refactor/new functionality exact but > I've created several patches with step-by-step changes. Hope this helps > in review. Nice, thanks. I've applied the changes and merged to 'next' for testing: ExternalProjec

Re: [cmake-developers] [Patch] ExternalProject: fix retry logic if error occurs

2016-05-19 Thread Ruslan Baratov via cmake-developers
It's a little bit tricky to split refactor/new functionality exact but I've created several patches with step-by-step changes. Hope this helps in review. Ruslo On 18-May-16 22:50, Brad King wrote: On 05/18/2016 03:30 PM, Ruslan Baratov via cmake-developers wrote: I've attached patch with app

Re: [cmake-developers] [Patch] ExternalProject: fix retry logic if error occurs

2016-05-18 Thread Brad King
On 05/18/2016 03:30 PM, Ruslan Baratov via cmake-developers wrote: > I've attached patch with applying retry logic in cases when status code > is not zero. Thanks. Please split the patch to perform the refactoring into the ExternalProject-$step.cmake.in files first and then make the logic change

[cmake-developers] [Patch] ExternalProject: fix retry logic if error occurs

2016-05-18 Thread Ruslan Baratov via cmake-developers
Hi, For now download retry attempt occurs in ExternalProject only if hash of archive mismatch. If error happens then script stop with FATAL_ERROR (example: https://ci.appveyor.com/project/ingenue/hunter/build/1.0.448/job/22kdl633f9w503ut). I've attached patch with applying retry logic in case