Re: [cmake-developers] [Review Request][3.1-rc1 regression] topic fix_link-line-dedup_regression

2014-11-10 Thread Daniele E. Domenichelli
On 10/11/14 16:49, Brad King wrote: > Thanks. Please rename the 'foo' and 'bar' libs to 'case5Foo' and > 'case5Bar' to avoid conflict with other cases in the future. Done: Rename the 'foo' and 'bar' libs to 'case5Foo' and 'case5Bar' http://www.cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;

Re: [cmake-developers] [Review Request][3.1-rc1 regression] topic fix_link-line-dedup_regression

2014-11-10 Thread Daniele E. Domenichelli
On 10/11/14 15:18, Brad King wrote: > However, the test does not fail for me even without the fix. I > think for 3.1.0-rc2 I will take this fix but not the test yet. > Please extend the topic to revise the test: The test fails for me on a ubuntu precise chroot using gcc 4.6.3 (I wasn't able to r

Re: [cmake-developers] [Review Request][3.1-rc1 regression] topic fix_link-line-dedup_regression

2014-11-10 Thread Brad King
On 11/10/2014 10:46 AM, Daniele E. Domenichelli wrote: >> - See if it can be integrated into the Tests/Dependency test, >> perhaps as a new Case5 directory. > > Done, see: > > Convert the test to use C only and move it into Tests/Dependency/Case5 > http://cmake.org/gitweb?p=cmake.git;a=commit

Re: [cmake-developers] [Review Request][3.1-rc1 regression] topic fix_link-line-dedup_regression

2014-11-10 Thread Brad King
On 11/09/2014 12:05 PM, Daniele E. Domenichelli wrote: > Fix regression in link order introduced by the link-line-dedup topic Thanks. I revised the implementation slightly to avoid prepending to a vector on every iteration. I've merged to 'next' for testing: Fix link line order when shared lib

[cmake-developers] [Review Request][3.1-rc1 regression] topic fix_link-line-dedup_regression

2014-11-09 Thread Daniele E. Domenichelli
Hello, Please review topic fix_link-line-dedup_regression: Fix regression in link order introduced by the link-line-dedup topic Some compilers will fail linking if an executable is linking to a library that is not used and a static library that uses the shared one. This patch reverse the direc