Re: [cmake-developers] Automatically set policies for shipped modules

2018-09-17 Thread Brad King
On 09/17/2018 09:14 AM, Craig Scott wrote: > We may also need to be careful about CMP0011 The policy scope added for our own modules can be marked as a "weak" scope. This means that specific policies can be set when the scope is first opened in C++ code, but policy settings inside the scope will

Re: [cmake-developers] Automatically set policies for shipped modules

2018-09-17 Thread Craig Scott
On Mon, Sep 17, 2018 at 9:07 PM Brad King wrote: > On 09/17/2018 04:01 AM, Rolf Eike Beer wrote: > > I suggest that every module included from the CMake installation is > > considered clean for whatever we do and automatically gets a policy > > scope push/pop right from the C++ level. > > That's

Re: [cmake-developers] Automatically set policies for shipped modules

2018-09-17 Thread Brad King
On 09/17/2018 04:01 AM, Rolf Eike Beer wrote: > I suggest that every module included from the CMake installation is > considered clean for whatever we do and automatically gets a policy > scope push/pop right from the C++ level. That's fine with me for policies like CMP0057 that affect the

[cmake-developers] Automatically set policies for shipped modules

2018-09-17 Thread Rolf Eike Beer
I have seen multiple commits basically wrapping Modules/* in cmake_policy(PUSH|POP). I neither find that appealing nor do I think that this will scale for maintenance. I suggest that every module included from the CMake installation is considered clean for whatever we do and automatically