Brad King wrote:
On 02/10/2014 03:41 AM, Stephen Kelly wrote:
diff --git a/Source/cmAddCustomCommandCommand.cxx
b/Source/cmAddCustomCommandCommand.cxx
index 5634849..e967e3c 100644
--- a/Source/cmAddCustomCommandCommand.cxx
+++ b/Source/cmAddCustomCommandCommand.cxx
@@ -164,6 +164,7
On 02/11/2014 07:16 AM, Stephen Kelly wrote:
Ok, I'm not sure how to handle these two items. I've never used the SOURCE
signature of add_custom_command, and the AddCustomCommandOldStyle method
seems to also relate to things I haven't used before, so I wouldn't know how
to explain the
Brad King wrote:
// For backwards compatibility replace varibles in source names.
- // This should eventually be removed.
+ // TODO: This should eventually be removed.
this-Makefile-ExpandVariablesInString(src);
A policy should be added to remove this behavior.
Any idea how to unit test
On 02/11/2014 11:48 AM, Stephen Kelly wrote:
Confirmed. I added CMP0049 to control this behavior.
Great.
Please include a Help/release/dev/backward-compatibility.rst
file with the relevant release note.
Thanks,
-Brad
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
Brad King wrote:
On 02/11/2014 11:48 AM, Stephen Kelly wrote:
Confirmed. I added CMP0049 to control this behavior.
Great.
Please include a Help/release/dev/backward-compatibility.rst
file with the relevant release note.
Will this make it into 3.0.0? Should I just add it to the existing
On 02/11/2014 12:00 PM, Stephen Kelly wrote:
Will this make it into 3.0.0?
Likely, since it is in the spirit of the other legacy cleanup
policies. If not we can always bump the policy version before
final integration.
Should I just add it to the existing release notes on master if so?
No,
On 02/11/2014 01:18 PM, Brad King wrote:
On 02/11/2014 12:00 PM, Stephen Kelly wrote:
Should I just add it to the existing release notes on master if so?
No, thanks. I'd like to get everyone in the habbit of adding
notes to the dev/ files and myself in the habbit of integrating
the notes.
Hi,
There are some places in cmake code which are commented as being for
backward compatibility, but which seem to be covered by no policy, and some
of which have a TODO item for addressing that.
diff --git a/Source/QtDialog/QCMake.cxx b/Source/QtDialog/QCMake.cxx
index 0fe5f8c..31eb79d
On 02/10/2014 03:41 AM, Stephen Kelly wrote:
diff --git a/Source/cmAddCustomCommandCommand.cxx
b/Source/cmAddCustomCommandCommand.cxx
index 5634849..e967e3c 100644
--- a/Source/cmAddCustomCommandCommand.cxx
+++ b/Source/cmAddCustomCommandCommand.cxx
@@ -164,6 +164,7 @@ bool
