Re: [cmake-developers] Branches on next

2014-02-12 Thread Ben Boeckel
On Tue, Feb 11, 2014 at 19:16:49 -0500, Matthew Woehlke wrote: > >If you're looking for corner-cases, check out the RunCMake.Syntax test > >in the source tree. If you can handle that, you're probably doing pretty > >well on the basics. > > Thanks; I may do that some time. Also look at RunCMake.va

Re: [cmake-developers] Branches on next

2014-02-12 Thread Ben Boeckel
On Wed, Feb 12, 2014 at 11:42:53 -0500, Ben Boeckel wrote: > I've addressed this…at least 2x speedup of Ninja's generate time in > ParaView (2.8.12.2: 95 seconds; branch with *all* performance changes: < > 40 seconds; something like 55 with just the Ninja changes). It will show > up on the stage in

Re: [cmake-developers] Branches on next

2014-02-12 Thread Ben Boeckel
On Wed, Feb 12, 2014 at 11:46:39 -0500, Matthew Woehlke wrote: > >That code isn't even on the radar for expensive code. It probably could > >be replaced with smaller code other than lex/yacc, but it's not worth > >the time if performance is the goal (removing lines, however…). Anything > >other tha

Re: [cmake-developers] Branches on next

2014-02-12 Thread Matthew Woehlke
On 2014-02-11 23:03, Ben Boeckel wrote: On Tue, Feb 11, 2014 at 19:16:49 -0500, Matthew Woehlke wrote: On 2014-02-11 17:54, Ben Boeckel wrote: ExpandVariablesInString is the part which takes a string which may have variables in it and dereferences them. Yes, that's why your changes are probab

Re: [cmake-developers] Branches on next

2014-02-12 Thread Ben Boeckel
On Tue, Feb 11, 2014 at 14:49:42 -0500, Ben Boeckel wrote: > (though Makefiles generate faster than the configure for > ParaView) and minimal for Ninja). I've addressed this…at least 2x speedup of Ninja's generate time in ParaView (2.8.12.2: 95 seconds; branch with *all* performanc

Re: [cmake-developers] Branches on next

2014-02-12 Thread Matthew Woehlke
On 2014-02-11 23:03, Ben Boeckel wrote: On Tue, Feb 11, 2014 at 19:16:49 -0500, Matthew Woehlke wrote: On 2014-02-11 17:54, Ben Boeckel wrote: Parsing in CMake is split into separate sections: the part which parses the lines into CMake's command calls and the part which expands variables (which

Re: [cmake-developers] Branches on next

2014-02-11 Thread Ben Boeckel
On Tue, Feb 11, 2014 at 19:16:49 -0500, Matthew Woehlke wrote: > On 2014-02-11 17:54, Ben Boeckel wrote: > >Parsing in CMake is split into separate sections: the part which parses > >the lines into CMake's command calls and the part which expands > >variables (which is why "${cmd}(${args})" isn't a

Re: [cmake-developers] Branches on next

2014-02-11 Thread Matthew Woehlke
On 2014-02-11 17:54, Ben Boeckel wrote: On Tue, Feb 11, 2014 at 17:18:22 -0500, Matthew Woehlke wrote: On a loosely related note, did you know that there are now at least two Python parsers for CMake script? (Besides I believe a C++ one in KDevelop...) 1. https://github.com/ijt/cmakelists_parsi

Re: [cmake-developers] Branches on next

2014-02-11 Thread Ben Boeckel
On Tue, Feb 11, 2014 at 17:18:22 -0500, Matthew Woehlke wrote: > On a loosely related note, did you know that there are now at least > two Python parsers for CMake script? (Besides I believe a C++ one in > KDevelop...) > > 1. https://github.com/ijt/cmakelists_parsing > 2. > https://github.com/mwo

Re: [cmake-developers] Branches on next

2014-02-11 Thread Matthew Woehlke
On 2014-02-11 14:49, Ben Boeckel wrote: I've just pushed two branches into next: dev/custom-parsers Replaces the parsers in cmMakefile::ExpandVariablesInString with custom code rather than lex/yacc. The parsers in cmGeneratorExpression::StripEmptyListElements

[cmake-developers] Branches on next

2014-02-11 Thread Ben Boeckel
Hi, I've just pushed two branches into next: dev/custom-parsers Replaces the parsers in cmMakefile::ExpandVariablesInString with custom code rather than lex/yacc. The parsers in cmGeneratorExpression::StripEmptyListElements cmSystemTools::ExpandListArguments an