Hi there,
I applied my patch to kdelibs to use the INTERFACE_INCLUDE_DIRECTORIES of
targets and remove include_directories() calls.
This resulted in a failure when moc'ing for dfaure:
http://thread.gmane.org/gmane.comp.kde.devel.buildsystem/7778/focus=7779
In his system, he has Qt 4 headers
Stephen Kelly wrote:
> find_package(Qt5Test)
>
Something like this is also needed to reproduce without patching Qt:
# Temporary until upstream does this:
foreach(_component Core Test)
if (TARGET Qt5::${_component})
set_property(TARGET Qt5::${_component}
APPEND PROPERTY
Stephen Kelly wrote:
> The bug can be reproduced with this cpp file:
>
>
> #include
>
> // Make CMAKE_AUTOMOC run on this file.
> class MyObject : public QObject
> {
> Q_OBJECT
> explicit MyObject(QObject *parent = 0)
> {
> QSKIP("The QSKIP macro has two args in Qt4 and one in Qt5.");
> }
> };
Stephen Kelly wrote:
> I recommend changing AUTOMOC to do the same appending. At some point, it
> seems that was done
>
>
http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/5293/focus=5297
>
> but a followup branch probably changed that to the current state.
>
I've pushed the au
On Monday 18 March 2013, Stephen Kelly wrote:
> Stephen Kelly wrote:
> > I recommend changing AUTOMOC to do the same appending. At some point, it
> > seems that was done
>
> http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/5293/focus
> =5297
>
> > but a followup branch probably ch
Alexander Neundorf wrote:
> The comment to your commit is not really correct.
>
> "The commit d2536579 (Automoc: fix regression #13667, broken build in
> phonon, 2012-11-19) changed Automoc to try to re-add the Qt header dir
> if it was stripped out as an implicit include from the moc command
> l
On 03/18/2013 07:24 PM, Stephen Kelly wrote:
> Alexander Neundorf wrote:
>
>> The comment to your commit is not really correct.
>>
>> "The commit d2536579 (Automoc: fix regression #13667, broken build in
>> phonon, 2012-11-19) changed Automoc to try to re-add the Qt header dir
>> if it was strippe
On Tuesday 19 March 2013, Stephen Kelly wrote:
> Alexander Neundorf wrote:
> > The comment to your commit is not really correct.
> >
> > "The commit d2536579 (Automoc: fix regression #13667, broken build in
> > phonon, 2012-11-19) changed Automoc to try to re-add the Qt header dir
> > if it was st
Brad King wrote:
> On 03/18/2013 07:24 PM, Stephen Kelly wrote:
>> Alexander Neundorf wrote:
>>
>>> The comment to your commit is not really correct.
>>>
>>> "The commit d2536579 (Automoc: fix regression #13667, broken build in
>>> phonon, 2012-11-19) changed Automoc to try to re-add the Qt heade
