Re: [cmake-developers] CMAKE_TOOLCHAIN_FILE and ExternalProject_Add

2015-04-28 Thread Stephen Kelly
Andrey Pokrovskiy wrote: > Hi, > > I'm using cmake and CMAKE_TOOLCHAIN_FILE to build the project and it's > dependencies. Some toolchain files have additional options (like API > version, target architecture, linker type, etc.) which you need to > pass to cmake command with "-D" in addition to th

Re: [cmake-developers] CMAKE_TOOLCHAIN_FILE and ExternalProject_Add

2015-04-27 Thread Brad King
On 04/26/2015 09:08 PM, David Cole via cmake-developers wrote: > I really don't see how you solve the problem by having a toolchain > file and some arbitrary set of variables to be passed down. Either you > have to put the CMAKE_TOOLCHAIN_ARGS into the toolchain file itself, > or you have to specif

Re: [cmake-developers] CMAKE_TOOLCHAIN_FILE and ExternalProject_Add

2015-04-26 Thread David Cole via cmake-developers
I realize that sometimes dependencies are necessary. But. There's a very strong argument to be made that projects should not have "a lot" of external dependencies. If you really need to tell an ExternalProject "build this external project the same way as the main one," you should probably write

Re: [cmake-developers] CMAKE_TOOLCHAIN_FILE and ExternalProject_Add

2015-04-26 Thread Andrey Pokrovskiy
Because it will be an ad-hoc solution. Also each time I will start using a new toolchain file (for another device/platform) I will need to modify that wrapper script. And each time I will override some toolchain variable I will need to look into that wrapper to verify that this variable will be for

Re: [cmake-developers] CMAKE_TOOLCHAIN_FILE and ExternalProject_Add

2015-04-26 Thread David Cole via cmake-developers
Why wouldn't you just write your own "toolchain wrapper" file which has all the variables you speak of, but also includes the "real" toolchain file, and then use the wrapper as your CMAKE_TOOLCHAIN_FILE value ... ? D On Sun, Apr 26, 2015 at 7:32 PM, Andrey Pokrovskiy wrote: > Hi, > > I'm usin

[cmake-developers] CMAKE_TOOLCHAIN_FILE and ExternalProject_Add

2015-04-26 Thread Andrey Pokrovskiy
Hi, I'm using cmake and CMAKE_TOOLCHAIN_FILE to build the project and it's dependencies. Some toolchain files have additional options (like API version, target architecture, linker type, etc.) which you need to pass to cmake command with "-D" in addition to the "-DCMAKE_TOOLCHAIN_FILE=" itself. S