Re: [cmake-developers] CMake 3.1 regression with incremental builds ?

2014-11-09 Thread Stephen Kelly
On 11/07/2014 05:52 PM, Brad King wrote: > On 11/07/2014 11:43 AM, Ben Boeckel wrote: >>> IIUC that is to create a cmSourceFile entry for the object file >>> corresponding to the source file. They are different entries. >> Do we know the source file doesn't exist at this point? If so, >> CreateSou

Re: [cmake-developers] CMake 3.1 regression with incremental builds ?

2014-11-07 Thread Brad King
On 11/07/2014 12:19 PM, Ben Boeckel wrote: > On Fri, Nov 07, 2014 at 11:52:45 -0500, Brad King wrote: >> OTOH, it is possible that application code tries to set a >> property on an object file ahead of time. > > AFAIK, CMake doesn't expose where it stores these files and has always > treated it as

Re: [cmake-developers] CMake 3.1 regression with incremental builds ?

2014-11-07 Thread Ben Boeckel
On Fri, Nov 07, 2014 at 11:52:45 -0500, Brad King wrote: > OTOH, it is possible that application code tries to set a > property on an object file ahead of time. AFAIK, CMake doesn't expose where it stores these files and has always treated it as an internal detail. Is this something we promise com

Re: [cmake-developers] CMake 3.1 regression with incremental builds ?

2014-11-07 Thread Brad King
On 11/07/2014 11:43 AM, Ben Boeckel wrote: >> IIUC that is to create a cmSourceFile entry for the object file >> corresponding to the source file. They are different entries. > > Do we know the source file doesn't exist at this point? If so, > CreateSourceFile would be better. My take: Normally

Re: [cmake-developers] CMake 3.1 regression with incremental builds ?

2014-11-07 Thread Ben Boeckel
On Fri, Nov 07, 2014 at 09:51:39 -0500, Brad King wrote: > On Thu, Nov 6, 2014 at 11:09 PM, Clinton Stimpson wrote: > > isn't the GetOrCreateSourceFile call superfluous if you have a > > pointer to the source file object in the iterator...? > > IIUC that is to create a cmSourceFile entry for the o

Re: [cmake-developers] CMake 3.1 regression with incremental builds ?

2014-11-07 Thread Brad King
On Thu, Nov 6, 2014 at 11:09 PM, Clinton Stimpson wrote: > I've put in a fix for this. > 580b668d genex: Preserve order while evaluating TARGET_OBJECTS Thanks. I bisected it down to cmTarget: Allow any generator expression in SOURCES property. http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h

Re: [cmake-developers] CMake 3.1 regression with incremental builds ?

2014-11-07 Thread David Cole via cmake-developers
I just looked at the diff, not the surrounding code, so forgive the question if it's obvious when inspecting the code.. but here's a question about your change before we push it into RC 2: Is "objectSources" guaranteed to contain the same set of objects as "mapping"? If so, I wonder why the c

Re: [cmake-developers] CMake 3.1 regression with incremental builds ?

2014-11-06 Thread clinton
I've put in a fix for this. 580b668d genex: Preserve order while evaluating TARGET_OBJECTS Can we put this in RC 2? Clint - Original Message - > > Using the netcdf project > ftp://ftp.unidata.ucar.edu/pub/netcdf/netcdf-4.3.2.tar.gz > > I see a problem with incremental builds doing a re

[cmake-developers] CMake 3.1 regression with incremental builds ?

2014-11-06 Thread Clinton Stimpson
Using the netcdf project ftp://ftp.unidata.ucar.edu/pub/netcdf/netcdf-4.3.2.tar.gz I see a problem with incremental builds doing a relink of libraries. Within my project, this leads to unnecessarily relinking of many executables every time I run cmake. For example: tar zxf netcdf-4.3.2.tar.g