I just realized that CTest only prioritized failed tests in parallel
test runs since it only modified COSTs in that case. So Casey was
quite
right noticing that there is a behavior change here.
I created a topic restore-serial-failed-test-order which limits
that
behavior to parallel test
Thanks Bill,
I think I can probably fix that by replacing the insert with a manual loop.
SSH access is being blocked here so I probably wont get to fix it before
I get home but looks like the client only builds nightly anyway :)
Nils
On 10/24/2013 03:40 PM, Bill Hoffman wrote:
On
On 10/23/2013 3:53 AM, Nils Gladitz wrote:
Hello Bill,
Would you approve a merge of the topic into next?
Who else should I be asking for approval?
e.g. is there a CTest specific maintainer?
Thanks in advance.
I am traveling right now at our NC Kitware office. There is someone
there that has
On 23.10.2013 15:15, Bill Hoffman wrote:
I am traveling right now at our NC Kitware office. There is someone
there that has a complicated system he wanted to try your changes on.
He should be able to get to that today. He also did some work on this
issue in the past. As soon as we try it
Bill and Nils,
I tried this on my large test suite under linux, and it seems to work. I
checked that the serial tests in my suite were still run alone (although in
my particular setup that happened to already occur). I also did not notice
any violation of the RESOURCE_LOCK constraints which are
On 23.10.2013 19:28, Casey Goodlett wrote:
Bill and Nils
Does this change the logic to run previously failed tests first or was
that already the case? I am not sure whether or not this is a better
behavior. Can running failed tests first be considered a separate
modification rather than
On 10/21/2013 2:39 PM, Nils Gladitz wrote:
I haven't see that fail on my local test runs.
Is it sporadic or does it fail for you consistently?
Never mind on this one. Looks like it fails for me without your changes.
-Bill
--
Powered by www.kitware.com
Visit other Kitware open-source
Hello Bill,
I've updated the topic with (I think) improved sorting.
Tests are now prioritized by depth within the dependency graph and
within each depth level they are further ordered by cost.
This gives better total test time for my test case and preserves
correctness in relation to
On 10/17/2013 4:41 PM, Nils Gladitz wrote:
I pushed my topic ctest-fix-run-serial to stage.
I am taking a look. It has been a long time since I looked at this
code. However, it seems like your patch removes the running of
dependent tests.
old code did this:
StartTest(int test)
...
Hello Bill, thanks for looking into this!
All four tests in my example are still run (as you can see in the test
output I provided).
This includes the dependent test.
What I did change is that all tests (from an dependency or otherwise)
are run from StartNextTests() which ensures that serial
On Thu, Oct 17, 2013 at 5:31 PM, Nils Gladitz nilsglad...@gmail.com wrote:
Hello Bill, thanks for looking into this!
All four tests in my example are still run (as you can see in the test
output I provided).
This includes the dependent test.
What I did change is that all tests (from an
StartTest() returns false without running the test if there are any
dependencies remaining.
Nils
On 17.10.2013 23:57, Bill Hoffman wrote:
On Thu, Oct 17, 2013 at 5:31 PM, Nils Gladitz nilsglad...@gmail.com
mailto:nilsglad...@gmail.com wrote:
Hello Bill, thanks for looking into this!
12 matches
Mail list logo
