On 10/10/2013 04:47 PM, Nils Gladitz wrote:
> Thanks for the feedback!
> I'll try to fix the commit message.
>
> As far as I can tell there shouldn't be any lines longer than 79 characters.
> I used the cmake developer script to set up my repository which seems to
> have set up a hook script whic
I think the logic is sound, and the hash is useful for truncating long
paths, but IMO you could skip the CM__ part.
The SCHEME_TYPE is apparent from the presence of a hash, which anyway
makes the id non-deterministic and unusable from other code. What does
the CM_ prefix mean, btw?
The hashes
Hi Nils
On 10/10/2013 9:14 PM, Nils Gladitz wrote:
I just pushed my first branch "wix-deterministic-ids" to the topic stage
Fantastic effort!
I chose to generate identifiers after the following format:
CM__(_)
I think the logic is sound, and the hash is useful for truncating long
paths,
Thanks for the feedback!
I'll try to fix the commit message.
As far as I can tell there shouldn't be any lines longer than 79 characters.
I used the cmake developer script to set up my repository which seems to
have set up a hook script which checks this on commit as well.
I even had to shorte
On 10/10/2013 03:14 PM, Nils Gladitz wrote:
> I just pushed my first branch "wix-deterministic-ids" to the topic stage
> (I hope).
> Since the whole workflow is quite new to me I'd be glad for any input
> that anyone may provide.
Yes, the topic is in the right place. Thanks.
Style comments:
-
I just pushed my first branch "wix-deterministic-ids" to the topic stage
(I hope).
Since the whole workflow is quite new to me I'd be glad for any input
that anyone may provide.
I chose to generate identifiers after the following format:
CM__(_)
is:
D - Directory
C - Component
F
