Re: [cmake-developers] Distinguishing MSYS2 (was: FindPythonLibs repaired for MINGW -vs- WIN32 version confusion)

2015-08-07 Thread Greg Jung
> > On Fri, Aug 7, 2015 at 1:16 PM, Brad King wrote: > > On 08/07/2015 05:25 AM, Ray Donnelly wrote: > >> CMake needs to be able to identify MSYS2 distinctly from both MINGW and > MSYS > >> first. Would a patch making that distinction be acceptable to CMake? > > Yes, I think that makes sense sinc

Re: [cmake-developers] Distinguishing MSYS2

2015-08-07 Thread Ray Donnelly
On Fri, Aug 7, 2015 at 2:21 PM, Brad King wrote: > On 08/07/2015 08:33 AM, Ray Donnelly wrote: >> Finally, there's the consideration as to whether "MSYS2" implies you >> are using just the minimum amount of the MSYS2 shell or whether you've >> gone all-in with MSYS2 > > CMAKE_SYSTEM_NAME should re

Re: [cmake-developers] Distinguishing MSYS2

2015-08-07 Thread Brad King
On 08/07/2015 08:33 AM, Ray Donnelly wrote: > Finally, there's the consideration as to whether "MSYS2" implies you > are using just the minimum amount of the MSYS2 shell or whether you've > gone all-in with MSYS2 CMAKE_SYSTEM_NAME should refer to the target application environment. If you're build

Re: [cmake-developers] Distinguishing MSYS2 (was: FindPythonLibs repaired for MINGW -vs- WIN32 version confusion)

2015-08-07 Thread Ray Donnelly
On Fri, Aug 7, 2015 at 1:16 PM, Brad King wrote: > On 08/07/2015 05:25 AM, Ray Donnelly wrote: >> CMake needs to be able to identify MSYS2 distinctly from both MINGW and MSYS >> first. Would a patch making that distinction be acceptable to CMake? > > Yes, I think that makes sense since the MSYS2

Re: [cmake-developers] Distinguishing MSYS2 (was: FindPythonLibs repaired for MINGW -vs- WIN32 version confusion)

2015-08-07 Thread Brad King
On 08/07/2015 05:25 AM, Ray Donnelly wrote: > CMake needs to be able to identify MSYS2 distinctly from both MINGW and MSYS > first. Would a patch making that distinction be acceptable to CMake? Yes, I think that makes sense since the MSYS2 environment is distinct from Windows, MinGW, MSYS, and Cy