Re: [cmake-developers] FindQt4.cmake Qt5 qmake

2014-06-27 Thread Brad King
On 06/27/2014 05:07 AM, Nils Gladitz wrote: > It has been pointed out that the change might still make sense since the > current behavior just removes the diagnostics in the > Qt4_FIND_QUIETLY case. Yes, I think the change still makes sense. You can rebase on 'master' and drop the revert/revert-

Re: [cmake-developers] FindQt4.cmake Qt5 qmake

2014-06-27 Thread Nils Gladitz
On 27.06.2014 09:56, Nils Gladitz wrote: On 25.06.2014 16:07, Nils Gladitz wrote: Eike pointed out misguided FindQt4.cmake diagnostics in my dashboard submissions: http://open.cdash.org/viewConfigure.php?buildid=3382423 I merged "FindQt4-ignore-qt5" for testing which I hope is an appropriate

Re: [cmake-developers] FindQt4.cmake Qt5 qmake

2014-06-27 Thread Nils Gladitz
On 25.06.2014 16:07, Nils Gladitz wrote: Eike pointed out misguided FindQt4.cmake diagnostics in my dashboard submissions: http://open.cdash.org/viewConfigure.php?buildid=3382423 I merged "FindQt4-ignore-qt5" for testing which I hope is an appropriate fix. I would appreciate it if those who

[cmake-developers] FindQt4.cmake Qt5 qmake

2014-06-25 Thread Nils Gladitz
Eike pointed out misguided FindQt4.cmake diagnostics in my dashboard submissions: http://open.cdash.org/viewConfigure.php?buildid=3382423 I merged "FindQt4-ignore-qt5" for testing which I hope is an appropriate fix. I would appreciate it if those who are more familiar with the module could v