Re: [cmake-developers] Generator expressions for archive|library|runtime output directory

2015-08-14 Thread Robert Goulet
Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] Generator expressions for archive|library|runtime output directory On 08/11/2015 01:51 PM, Robert Goulet wrote: Here's the updated patch for OUTPUT_DIRECTORY supporting genex. Thanks. Applied with a few tweaks: cmTarget: Detect

Re: [cmake-developers] Generator expressions for archive|library|runtime output directory

2015-08-13 Thread Brad King
On 08/11/2015 01:51 PM, Robert Goulet wrote: Here's the updated patch for OUTPUT_DIRECTORY supporting genex. Thanks. Applied with a few tweaks: cmTarget: Detect and diagnose recursion in GetOutputInfo http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e36a05fd Add generator expression

Re: [cmake-developers] Generator expressions for archive|library|runtime output directory

2015-08-13 Thread Robert Goulet
-developers] Generator expressions for archive|library|runtime output directory On 08/11/2015 01:51 PM, Robert Goulet wrote: Here's the updated patch for OUTPUT_DIRECTORY supporting genex. Thanks. Applied with a few tweaks: cmTarget: Detect and diagnose recursion in GetOutputInfo http

Re: [cmake-developers] Generator expressions for archive|library|runtime output directory

2015-08-11 Thread Robert Goulet
! -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Monday, August 10, 2015 11:48 AM To: Robert Goulet robert.gou...@autodesk.com Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] Generator expressions for archive|library|runtime output directory On 08

Re: [cmake-developers] Generator expressions for archive|library|runtime output directory

2015-08-10 Thread Brad King
On 08/10/2015 11:29 AM, Robert Goulet wrote: could it be a problem of recursion? Yes, that is exactly the problem. perhaps it would be better to check for recursion directly in the generator expressions evaluation Some generator expressions do support recursion. While some checks may be

Re: [cmake-developers] Generator expressions for archive|library|runtime output directory

2015-08-10 Thread Robert Goulet
-developers@cmake.org; Stephen Kelly steve...@gmail.com Subject: Re: [cmake-developers] Generator expressions for archive|library|runtime output directory On Tue, Jul 21, 2015 at 10:03:42 -0400, Brad King wrote: Okay. I've made a note about this issue to make sure it is fixed before 3.4. Meanwhile I

Re: [cmake-developers] Generator expressions for archive|library|runtime output directory

2015-07-21 Thread Ben Boeckel
On Tue, Jul 21, 2015 at 10:03:42 -0400, Brad King wrote: Okay. I've made a note about this issue to make sure it is fixed before 3.4. Meanwhile I have another comment on genex support in the OUTPUT_DIRECTORY properties. Currently the properties support both

Re: [cmake-developers] Generator expressions for archive|library|runtime output directory

2015-07-21 Thread Brad King
On 07/17/2015 02:34 PM, Robert Goulet wrote: I'm going to be away for a few weeks, is it ok if the master branch stays in that state for a while? Okay. I've made a note about this issue to make sure it is fixed before 3.4. Meanwhile I have another comment on genex support in the

Re: [cmake-developers] Generator expressions for archive|library|runtime output directory

2015-07-17 Thread Brad King
On 07/15/2015 05:27 PM, Robert Goulet wrote: I didn't know about the two signature of cmCompiledGeneratorExpression::Evaluate, what's the difference? As for the TARGET_PROPERTY generator expression, are you suggesting this could potentially be an issue? I haven't tried it. If

Re: [cmake-developers] Generator expressions for archive|library|runtime output directory

2015-07-17 Thread Robert Goulet
To: Robert Goulet Cc: Stephen Kelly; cmake-developers@cmake.org Subject: Re: [cmake-developers] Generator expressions for archive|library|runtime output directory On 07/15/2015 05:27 PM, Robert Goulet wrote: I didn't know about the two signature of cmCompiledGeneratorExpression::Evaluate, what's

Re: [cmake-developers] Generator expressions for archive|library|runtime output directory

2015-07-17 Thread Brad King
On 07/17/2015 10:55 AM, Robert Goulet wrote: Ok I'd like to fix the crash, what is the clean way to deal with this kind of situation? I'm guessing this might be a problem that was solved elsewhere for other cases before? I don't recall other cases where this specific problem has come up.

Re: [cmake-developers] Generator expressions for archive|library|runtime output directory

2015-07-17 Thread Robert Goulet
-developers] Generator expressions for archive|library|runtime output directory On 07/17/2015 10:55 AM, Robert Goulet wrote: Ok I'd like to fix the crash, what is the clean way to deal with this kind of situation? I'm guessing this might be a problem that was solved elsewhere for other cases

Re: [cmake-developers] Generator expressions for archive|library|runtime output directory

2015-07-15 Thread Stephen Kelly
Robert Goulet wrote: Greetings! Patch in attachment for all OUTPUT_DIRECTORY variants to support generator expressions. Thanks! There are two signatures for cmCompiledGeneratorExpression::Evaluate. Did you use the correct one? Does this support all generator expressions? Including

Re: [cmake-developers] Generator expressions for archive|library|runtime output directory

2015-07-15 Thread Robert Goulet
-developers [mailto:cmake-developers-boun...@cmake.org] On Behalf Of Stephen Kelly Sent: Wednesday, July 15, 2015 5:17 PM To: cmake-developers@cmake.org Subject: Re: [cmake-developers] Generator expressions for archive|library|runtime output directory Robert Goulet wrote: Greetings! Patch

[cmake-developers] Generator expressions for archive|library|runtime output directory

2015-07-14 Thread Robert Goulet
Greetings! Patch in attachment for all OUTPUT_DIRECTORY variants to support generator expressions. Thanks! -Robert Goulet output-dir-genex.patch Description: output-dir-genex.patch -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: