Re: [cmake-developers] How to handle package Config.cmake files with dependencies ?

2012-03-18 Thread Alexander Neundorf
On Saturday 17 March 2012, Alexander Neundorf wrote: On Tuesday 13 March 2012, Brad King wrote: On 3/13/2012 4:23 PM, Alexander Neundorf wrote: Then force-push back to the stage for another review. Done. Thanks. I rewrote and force-pushed the topic to make a few changes:

Re: [cmake-developers] How to handle package Config.cmake files with dependencies ?

2012-03-17 Thread Alexander Neundorf
On Tuesday 13 March 2012, Brad King wrote: On 3/13/2012 4:23 PM, Alexander Neundorf wrote: Then force-push back to the stage for another review. Done. Thanks. I rewrote and force-pushed the topic to make a few changes: (1) Tweaked the commit message of the main commit (2) Tweaked

Re: [cmake-developers] How to handle package Config.cmake files with dependencies ?

2012-03-13 Thread Brad King
On Sat, Mar 10, 2012 at 7:35 AM, Alexander Neundorf neund...@kde.org wrote: There is now a branch find_package_set_FOUND_VariableInConfigFile on stage. It behaves almost as you suggested: the _FOUND variable is only removed before the Config file is loaded, if the variable exists and is false.

Re: [cmake-developers] How to handle package Config.cmake files with dependencies ?

2012-03-13 Thread Alexander Neundorf
On Tuesday 13 March 2012, Brad King wrote: On 3/13/2012 4:23 PM, Alexander Neundorf wrote: Then force-push back to the stage for another review. Done. Thanks. I rewrote and force-pushed the topic to make a few changes: (1) Tweaked the commit message of the main commit (2) Tweaked

Re: [cmake-developers] How to handle package Config.cmake files with dependencies ?

2012-03-10 Thread Alexander Neundorf
On Wednesday 07 March 2012, Michael Hertling wrote: On 02/27/2012 10:05 PM, Brad King wrote: On 2/27/2012 3:37 PM, Michael Wild wrote: On 02/27/2012 09:15 PM, Alexander Neundorf wrote: When the FooConfig.cmake has been found, Foo_FOUND is set to TRUE: // Set a variable marking whether

Re: [cmake-developers] How to handle package Config.cmake files with dependencies ?

2012-03-10 Thread Alexander Neundorf
On Monday 27 February 2012, Brad King wrote: On 2/27/2012 3:37 PM, Michael Wild wrote: On 02/27/2012 09:15 PM, Alexander Neundorf wrote: When the FooConfig.cmake has been found, Foo_FOUND is set to TRUE: // Set a variable marking whether the package was found. std::string

Re: [cmake-developers] How to handle package Config.cmake files with dependencies ?

2012-03-10 Thread Alexander Neundorf
Hi, ...some comments inline, but the main point comes at the end. On Wednesday 07 March 2012, Michael Hertling wrote: On 02/27/2012 09:15 PM, Alexander Neundorf wrote: Hi, I think find_package in Config mode might still need some more work. When the FooConfig.cmake has been found,

Re: [cmake-developers] How to handle package Config.cmake files with dependencies ?

2012-03-10 Thread Alexander Neundorf
On Saturday 10 March 2012, Alexander Neundorf wrote: ... What it does is it requires a lot of manual checking in the users CMakeLists.txt (because they have to check for each requested component individually). How about find_package(Foo COMPONENTS Bar Blub OPTIONAL_COMPONENTS Zot Zat ) ?

Re: [cmake-developers] How to handle package Config.cmake files with dependencies ?

2012-03-10 Thread Alexander Neundorf
On Saturday 10 March 2012, Alexander Neundorf wrote: On Saturday 10 March 2012, Alexander Neundorf wrote: ... What it does is it requires a lot of manual checking in the users CMakeLists.txt (because they have to check for each requested component individually). How about

Re: [cmake-developers] How to handle package Config.cmake files with dependencies ?

2012-03-07 Thread Michael Hertling
On 02/27/2012 10:05 PM, Brad King wrote: On 2/27/2012 3:37 PM, Michael Wild wrote: On 02/27/2012 09:15 PM, Alexander Neundorf wrote: When the FooConfig.cmake has been found, Foo_FOUND is set to TRUE: // Set a variable marking whether the package was found. std::string foundVar =

Re: [cmake-developers] How to handle package Config.cmake files with dependencies ?

2012-03-07 Thread Michael Hertling
On 02/27/2012 09:15 PM, Alexander Neundorf wrote: Hi, I think find_package in Config mode might still need some more work. When the FooConfig.cmake has been found, Foo_FOUND is set to TRUE: // Set a variable marking whether the package was found. std::string foundVar = this-Name;

Re: [cmake-developers] How to handle package Config.cmake files with dependencies ?

2012-03-07 Thread Brad King
On 3/7/2012 9:49 AM, Michael Hertling wrote: been found, but in module mode, AFAIK, it's set to Foo_DIR-NOTFOUND even if a find module has succeeded The Foo_DIR variable is not set or added to the cache at all if a FindFoo module is loaded regardless of whether it succeeds. It is only if no

Re: [cmake-developers] How to handle package Config.cmake files with dependencies ?

2012-02-28 Thread Alexander Neundorf
On Monday 27 February 2012, Brad King wrote: On 2/27/2012 3:37 PM, Michael Wild wrote: On 02/27/2012 09:15 PM, Alexander Neundorf wrote: When the FooConfig.cmake has been found, Foo_FOUND is set to TRUE: // Set a variable marking whether the package was found. std::string

Re: [cmake-developers] How to handle package Config.cmake files with dependencies ?

2012-02-28 Thread Brad King
On 2/28/2012 1:48 PM, Alexander Neundorf wrote: Do you think that needs a policy ? I'm not sure. It's pretty obscure. The code currently does: // Set a variable marking whether the package was found. std::string foundVar = this-Name; foundVar += _FOUND;

[cmake-developers] How to handle package Config.cmake files with dependencies ?

2012-02-27 Thread Alexander Neundorf
Hi, I think find_package in Config mode might still need some more work. When the FooConfig.cmake has been found, Foo_FOUND is set to TRUE: // Set a variable marking whether the package was found. std::string foundVar = this-Name; foundVar += _FOUND; This means it is true in all cases

Re: [cmake-developers] How to handle package Config.cmake files with dependencies ?

2012-02-27 Thread Michael Wild
On 02/27/2012 09:15 PM, Alexander Neundorf wrote: Hi, I think find_package in Config mode might still need some more work. When the FooConfig.cmake has been found, Foo_FOUND is set to TRUE: // Set a variable marking whether the package was found. std::string foundVar = this-Name;

Re: [cmake-developers] How to handle package Config.cmake files with dependencies ?

2012-02-27 Thread Brad King
On 2/27/2012 3:37 PM, Michael Wild wrote: On 02/27/2012 09:15 PM, Alexander Neundorf wrote: When the FooConfig.cmake has been found, Foo_FOUND is set to TRUE: // Set a variable marking whether the package was found. std::string foundVar = this-Name; foundVar += _FOUND; This means it