On 03/01/2015 04:38 PM, Domen Vrankar wrote:
> Attached are refactored patches.
Thanks. I've placed them in KWSys for testing here:
http://review.source.kitware.com/#/c/19377/
http://review.source.kitware.com/#/c/19378/
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and
> For the other two changes, please refactor things to avoid
> use of function-local classes. They will likely not work
> on the older compilers KWSys supports.
>
> Also, please use the coding style of "this->Member" when
> referencing class members from method code.
Attached are refactored patch
On 02/23/2015 12:55 PM, Brad King wrote:
> On 02/21/2015 04:33 PM, Domen Vrankar wrote:
>> Attached are patches with fixed patch 3.
>
> Thanks. I'll start with the SystemTools change which I've split
> out into its own commit and pushed here:
>
> http://review.source.kitware.com/#/c/19304/
Tha
> Attached are patches for KWSys Glob and SystemTools (with changes
> required by Glob).
I apologize for spamming...
After rewriting CMake tests with directories instead of symlinks I
noticed that patch 3 was not handling basic directory case.
Attached are patches with fixed patch 3.
Thanks,
Do
> FYI, the proposed GetCanonicalPath already exists in KWSys as
> SystemTools::GetRealPath. It returns the unchanged path on error.
> That could be extended to take an optional second argument as a
> pointer to a buffer describing the error. If the argument is NULL
> use the current behavior. Ot
On 02/16/2015 02:47 PM, Domen Vrankar wrote:
> I've noticed that exceptions are not used but was not certain how else
> to handle this
FYI, the proposed GetCanonicalPath already exists in KWSys as
SystemTools::GetRealPath. It returns the unchanged path on error.
That could be extended to take an
> I'll get the KWSys patch through. Once it is integrated into
> CMake then you can rebase the CMake part of the change on that.
>
> However, please revise the logic in the KWSys patch to avoid
> using exceptions.
I've noticed that exceptions are not used but was not certain how else
to handle th
On 02/15/2015 03:04 PM, Domen Vrankar wrote:
> I tried to register to http://review.source.kitware.com so that I
> would be able to commit patches to KWSys repository but after I put in
> my OpenID I got a "Not Found" error.
I'll be in touch off-list about this.
> How can I contribute this patch?
Hi everyone,
I am having problems with a patch for Glob functionality because Glob
is part of KWSys repository.
I tried to register to http://review.source.kitware.com so that I
would be able to commit patches to KWSys repository but after I put in
my OpenID I got a "Not Found" error.
How can I
