Re: [cmake-developers] Modules/GetPrequisites.cmake issues

2015-08-03 Thread Clinton Stimpson
On Monday, August 03, 2015 10:22:18 AM Brad King wrote: > On 07/30/2015 10:56 AM, Brad King wrote: > > Thanks! Applied: > Those patches exposed a bug in FindMPI, so I fixed that and > rebased the other changes on it: > > FindMPI: Drop unnecessary and incorrect use of GetPrerequisites > http://c

Re: [cmake-developers] Modules/GetPrequisites.cmake issues

2015-08-03 Thread Bill Somerville
On 03/08/2015 15:22, Brad King wrote: Hi Brad, On 07/30/2015 10:56 AM, Brad King wrote: Thanks! Applied: Those patches exposed a bug in FindMPI, so I fixed that and rebased the other changes on it: Glad my patch flushed out an unrelated defect. OTOH there are many other uses of execute_proc

Re: [cmake-developers] Modules/GetPrequisites.cmake issues

2015-08-03 Thread Brad King
On 07/30/2015 10:56 AM, Brad King wrote: > Thanks! Applied: Those patches exposed a bug in FindMPI, so I fixed that and rebased the other changes on it: FindMPI: Drop unnecessary and incorrect use of GetPrerequisites http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1c46b6ae GetPrerequisite

Re: [cmake-developers] Modules/GetPrequisites.cmake issues

2015-07-30 Thread Brad King
On 07/29/2015 12:51 PM, Bill Somerville wrote: > Revised patches attached. Thanks! Applied: GetPrerequisites: Add error checks for execute_process() calls http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=35626e57 GetPrerequisites: Optionally filter "objdump" output for speed http://cmake.

Re: [cmake-developers] Modules/GetPrequisites.cmake issues

2015-07-29 Thread Bill Somerville
On 29/07/2015 14:37, Brad King wrote: Hi Brad, On 07/28/2015 06:02 PM, Bill Somerville wrote: attached is a patch that addresses some issues recently discussed on the users list. ... If you're comfortable enough with Git, please split this part out into a preceding patch with its own explanati

Re: [cmake-developers] Modules/GetPrequisites.cmake issues

2015-07-29 Thread Bill Somerville
On 29/07/2015 16:07, Bill Hoffman wrote: Hi Bill, On 7/29/2015 10:17 AM, Bill Somerville wrote: Is there a reason not to look for objdump before dumpbin? I was under the impression that dumpbin was selected first for non-MinGW Windows builds, I have no idea if objdump works with binaries produc

Re: [cmake-developers] Modules/GetPrequisites.cmake issues

2015-07-29 Thread Bill Hoffman
On 7/29/2015 10:17 AM, Bill Somerville wrote: Is there a reason not to look for objdump before dumpbin? I was under the impression that dumpbin was selected first for non-MinGW Windows builds, I have no idea if objdump works with binaries produced by compilers other than GNU/CLang. This is why I

Re: [cmake-developers] Modules/GetPrequisites.cmake issues

2015-07-29 Thread Bill Somerville
On 29/07/2015 14:37, Brad King wrote: Hi Brad, On 07/28/2015 06:02 PM, Bill Somerville wrote: ... As there doesn't seem to be a reliable way of detecting MinGW callers of fixup_bundle() may have to set the variable gp_tool to "objdump" if dumpbin.exe is installed on the build machine to

Re: [cmake-developers] Modules/GetPrequisites.cmake issues

2015-07-29 Thread Brad King
On 07/28/2015 06:02 PM, Bill Somerville wrote: > attached is a patch that addresses some issues recently discussed on the > users list. Thanks for working on this! > As there doesn't seem to be a reliable way of detecting MinGW callers > of fixup_bundle() may have to set the variable gp_tool to

[cmake-developers] Modules/GetPrequisites.cmake issues

2015-07-28 Thread Bill Somerville
Hi All, attached is a patch that addresses some issues recently discussed on the users list. I'm no CMake expert so I don't know if I have done things in the best way. One area I do not fully understand is how to detect MinGW, If I could then objdump could be chosen as the preferred library