On 19.02.2012 07:21, Peter Collingbourne wrote:
This caused custom commands to be double encoded, causing a test failure
on *nix. I reverted part of your changes to fix the test failures and
also had a look at implementing the escaping rules correctly. With the
changes I made, I was able to
Why does the ninja generator need to use? I am pretty sure the other
CMake generators do not need to use.
Most of them come from the working directory: cd foo g++
They could be worked around easly by adding a new variable to the rules.
Seems like there should be a better way to run a
On 04.02.2012 11:48, Bill Hoffman wrote:
Why does the ninja generator need to use? I am pretty sure the other
CMake generators do not need to use.
Most of them come from the working directory: cd foo g++
They could be worked around easly by adding a new variable to the rules.
Seems
On 2/1/2012 10:23 PM, Bill Hoffman wrote:
On 2/1/2012 4:19 PM, Peter Kümmel wrote:
We can't use cmd. Maybe ninja could be fixed.
If not, you could come up with something that uses CMake scripts.
cmake -E foo.cmake
foo.cmake
execute_process()
Not ideal, but until ninja figures it
On 2/2/2012 8:30 AM, Brad King wrote:
On 2/1/2012 10:23 PM, Bill Hoffman wrote:
On 2/1/2012 4:19 PM, Peter Kümmel wrote:
We can't use cmd. Maybe ninja could be fixed.
If not, you could come up with something that uses CMake scripts.
cmake -E foo.cmake
foo.cmake
execute_process()
On Thu, Feb 2, 2012 at 4:34 PM, Bill Hoffman bill.hoff...@kitware.com wrote:
On 2/2/2012 8:30 AM, Brad King wrote:
On 2/1/2012 10:23 PM, Bill Hoffman wrote:
On 2/1/2012 4:19 PM, Peter Kümmel wrote:
We can't use cmd. Maybe ninja could be fixed.
If not, you could come up with something
On 2/2/2012 10:41 AM, Nicolas Desprès wrote:
When you use scripts or file like link.txt you lose the power of the
special $in and $out variables or variable in general that are
expanded in the rule.
I am not sure what those are, must be a Ninja thing...
With windows, unless you have
Sorry for asking a question without looking into the details first...
But
Why does the ninja generator need to use ? I am pretty sure the other
CMake generators do not need to use .
-Bill
--
Bill Hoffman
Kitware, Inc.
28 Corporate Drive
Clifton Park, NY 12065
2012/2/2 Bill Hoffman bill.hoff...@kitware.com:
Sorry for asking a question without looking into the details first...
But
No problem.
Why does the ninja generator need to use ? I am pretty sure the other
CMake generators do not need to use .
Most of them come from the working
On Tue, Jan 31, 2012 at 10:42:40PM -0500, Bill Hoffman wrote:
On 1/31/2012 5:58 PM, Peter Collingbourne wrote:
That will
be handy when it comes time to integrate this work upstream because
KWSys is shared with other projects.
Why isn't that time now? The generator already works and
On 01.02.2012 20:56, Peter Collingbourne wrote:
On Tue, Jan 31, 2012 at 10:42:40PM -0500, Bill Hoffman wrote:
On 1/31/2012 5:58 PM, Peter Collingbourne wrote:
That will
be handy when it comes time to integrate this work upstream because
KWSys is shared with other projects.
Why isn't
On 01.02.2012 21:04, Peter Collingbourne wrote:
On Tue, Jan 31, 2012 at 10:58:32PM +, Peter Collingbourne wrote:
On Tue, Jan 31, 2012 at 05:06:28PM -0500, Brad King wrote:
On 1/31/2012 4:44 PM, Peter Kümmel wrote:
OK, thanks. I already noticed the usage of OutputFormat::SHELL.
Then I have
On 31.01.2012 23:40, Peter Collingbourne wrote:
On Tue, Jan 31, 2012 at 10:32:23PM +0100, Peter Kümmel wrote:
On 31.01.2012 16:19, Peter Collingbourne wrote:
On Tue, Jan 31, 2012 at 12:15:59AM +0100, Peter Kümmel wrote:
- Paths like 'c:\' - Ninja now supports colon escaping c: - c$:
Is
On 31.01.2012 04:55, Bill Hoffman wrote:
- Paths like 'c:\' - Ninja now supports colon escaping c: - c$:
Is there a single place where the escaping could be done?
Can we use Posix paths in the windows ninja generator instead of windows
paths? I am guessing ninja would be happier with them.
On 31.01.2012 16:19, Peter Collingbourne wrote:
On Tue, Jan 31, 2012 at 12:15:59AM +0100, Peter Kümmel wrote:
I played a bit with the Ninja generator on Windows,
and added some hacks to make it a bit running:
https://github.com/syntheticpp/CMake/commit/0a55b61271106eb7c3319340f2c54f6bab3c0f8b
Therefore the question, if there is a single place where
all the slashes could be replaced by backslashes before we write
them down to the ninja file.
All of that is done in the cmLocalGenerator for the NMake and Jom
generators that use windows paths:
enum RelativeRoot { NONE, FULL,
On 1/31/2012 4:44 PM, Peter Kümmel wrote:
OK, thanks. I already noticed the usage of OutputFormat::SHELL.
Then I have to extend cmLocalGenerator by a Ninja case. It will be
similar to NMake but additionally replaces colons by '$:'.
Should I add kwsysSystem_Shell_Flag_Ninja in System.h?
Yes.
On Tue, Jan 31, 2012 at 10:32 PM, Peter Kümmel syntheti...@gmx.net wrote:
On 31.01.2012 16:19, Peter Collingbourne wrote:
On Tue, Jan 31, 2012 at 12:15:59AM +0100, Peter Kümmel wrote:
I played a bit with the Ninja generator on Windows,
and added some hacks to make it a bit running:
On Tue, Jan 31, 2012 at 10:32:23PM +0100, Peter Kümmel wrote:
On 31.01.2012 16:19, Peter Collingbourne wrote:
On Tue, Jan 31, 2012 at 12:15:59AM +0100, Peter Kümmel wrote:
- Paths like 'c:\' - Ninja now supports colon escaping c: - c$:
Is there a single place where the escaping could be
I played a bit with the Ninja generator on Windows,
and added some hacks to make it a bit running:
https://github.com/syntheticpp/CMake/commit/0a55b61271106eb7c3319340f2c54f6bab3c0f8b
Here are the problems I found so far:
- Paths like 'c:\' - Ninja now supports colon escaping c: - c$:
Is
20 matches
Mail list logo